clang-format: [JS] ASI insertion after boolean literals.

[mprobst]

Summary

Before when a semicolon was missing after a boolean literal:

a = true
return 1;

clang-format would parse this as one line and format as:

a = true return 1;

It turns out that C++ does not consider true and false to be literals, we
have to check for that explicitly.

[djasper]

Interesting.. Would have expected true/false to be literals as well, but ok :).

lib/Format/UnwrappedLineParser.cpp

return FormatTok->is(tok::identifier) &&
                               Keywords.kw_is, Keywords.kw_let, Keywords.kw_var,
                               Keywords.kw_abstract, Keywords.kw_extends,
                               Keywords.kw_implements, Keywords.kw_instanceof,
                               Keywords.kw_interface, Keywords.kw_throws));
 }
 
 static bool mustBeJSIdentOrValue(const AdditionalKeywords &Keywords,
                                  const FormatToken *FormatTok) {
-  return FormatTok->Tok.isLiteral() || mustBeJSIdent(Keywords, FormatTok);
+  return FormatTok->Tok.isLiteral() ||
+         FormatTok->isOneOf(tok::kw_true, tok::kw_false) ||
+         mustBeJSIdent(Keywords, FormatTok);
 }
 
 // isJSDeclOrStmt returns true if |FormatTok| starts a declaration or statement
 // when encountered after a value (see mustBeJSIdentOrValue).
 static bool isJSDeclOrStmt(const AdditionalKeywords &Keywords,
                            const FormatToken *FormatTok) {
   return FormatTok->isOneOf(
       tok::kw_return, Keywords.kw_yield,

unittests/Format/FormatTestJS.cpp

verifyFormat("a\n"
                " class X {}");
   verifyFormat("var a", "var\n"
                         "a");
   verifyFormat("x instanceof String", "x\n"
                                       "instanceof\n"
                                       "String");
   verifyFormat("function f(@Foo bar) {}", "function f(@Foo\n"
                                           "  bar) {}");
+  verifyFormat("a = true\n"
+               "return 1",
+               "a = true\n"
+               "  return   1");
+  verifyFormat("a = 'true'\n"
+               "return 1",
+               "a = 'true'\n"
+               "  return   1");
 }
 
 TEST_F(FormatTestJS, ClosureStyleCasts) {
   verifyFormat("var x = /** @type {foo} */ (bar);");
 }
 
 TEST_F(FormatTestJS, TryCatch) {
   verifyFormat("try {\n"