This patch is the unit test for conditionally eliminate library calls patch,
which is being reviewed here:
https://reviews.llvm.org/D24414
Details
Details
- Reviewers
davidxl mehdi_amini hfinkel
Diff Detail
Diff Detail
Event Timeline
SingleSource/Regression/C++/cdce_macro.inc | ||
---|---|---|
16 ↗ | (On Diff #70882) | use upper case for macro? Why is the macro needed? |
20 ↗ | (On Diff #70882) | why 10 ? |
21 ↗ | (On Diff #70882) | -->TEST_VAL_RANGE? |
33 ↗ | (On Diff #70882) | -->TEST_VAL This macro be used in TEST_VAL_RANGE definition |
33 ↗ | (On Diff #70882) | make it take a value argument |
SingleSource/Regression/C++/cdce_macro.inc | ||
---|---|---|
16 ↗ | (On Diff #70882) | OK. used the upper case in the new patch. We need this because, we need to postfix "l" or "f" to the name for long double and float. For double type, we don't need to do anything, that's the default here. |
20 ↗ | (On Diff #70882) | just an arbitrary number. Do you want it to be a larger number? testing all the integers seems to be excessive. |
Comment Actions
Integrated David's review comments and changed the file names in sync to https://reviews.llvm.org/D24414