This is an archive of the discontinued LLVM Phabricator instance.

Differential D24401

clang-format: Add Java detection to git-clang-format.
ClosedPublic

Authored by lhchavez on Sep 9 2016, 8:36 AM.

Download Raw Diff

Details

Reviewers

Commits

rG815e9bbdbd64: clang-format: Add Java detection to git-clang-format.
rC281294: clang-format: Add Java detection to git-clang-format.
rL281294: clang-format: Add Java detection to git-clang-format.

Summary

This change adds "java" to the list of known extensions that clang-format supports.

Diff Detail

Event Timeline

lhchavez updated this revision to Diff 70841.Sep 9 2016, 8:36 AM

lhchavez retitled this revision from to clang-format: Add Java detection to git-clang-format..

lhchavez updated this object.

lhchavez added a reviewer: djasper.

lhchavez set the repository for this revision to rL LLVM.

lhchavez added subscribers: cfe-commits, srhines.

Looks good.

This revision is now accepted and ready to land.Sep 10 2016, 1:27 AM

Generated the diff properly this time, and it now shows full context.

Using arcanist to fix the paths as well

Rebased to r281293

Closed by commit rL281294: clang-format: Add Java detection to git-clang-format. (authored by srhines). · Explain WhySep 12 2016, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

tools/

clang-format/

git-clang-format

1 line

Diff 71087

tools/clang-format/git-clang-format

	Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines		def main():
	default_extensions = ','.join([			default_extensions = ','.join([
	# From clang/lib/Frontend/FrontendOptions.cpp, all lower case			# From clang/lib/Frontend/FrontendOptions.cpp, all lower case
	'c', 'h', # C			'c', 'h', # C
	'm', # ObjC			'm', # ObjC
	'mm', # ObjC++			'mm', # ObjC++
	'cc', 'cp', 'cpp', 'c++', 'cxx', 'hpp', # C++			'cc', 'cp', 'cpp', 'c++', 'cxx', 'hpp', # C++
	# Other languages that clang-format supports			# Other languages that clang-format supports
	'proto', 'protodevel', # Protocol Buffers			'proto', 'protodevel', # Protocol Buffers
				'java', # Java
	'js', # JavaScript			'js', # JavaScript
	'ts', # TypeScript			'ts', # TypeScript
	])			])

	p = argparse.ArgumentParser(			p = argparse.ArgumentParser(
	usage=usage, formatter_class=argparse.RawDescriptionHelpFormatter,			usage=usage, formatter_class=argparse.RawDescriptionHelpFormatter,
	description=desc)			description=desc)
	p.add_argument('--binary',			p.add_argument('--binary',
	▲ Show 20 Lines • Show All 398 Lines • Show Last 20 Lines