Page MenuHomePhabricator

lhchavez (Luis Héctor Chávez)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2016, 2:21 PM (157 w, 6 d)

Recent Activity

Dec 22 2017

lhchavez abandoned D41498: [libcxx] Add clang negative thread safety assertions to std::mutex.
Dec 22 2017, 8:38 AM

Dec 21 2017

lhchavez added inline comments to D41498: [libcxx] Add clang negative thread safety assertions to std::mutex.
Dec 21 2017, 2:15 PM
lhchavez added a reviewer for D41498: [libcxx] Add clang negative thread safety assertions to std::mutex: mclow.lists.
Dec 21 2017, 9:24 AM
lhchavez created D41498: [libcxx] Add clang negative thread safety assertions to std::mutex.
Dec 21 2017, 9:22 AM

Dec 13 2016

lhchavez added inline comments to D27377: clang-format: Support the Java 8 'default' method modifier.
Dec 13 2016, 12:30 PM
lhchavez updated the diff for D27377: clang-format: Support the Java 8 'default' method modifier.

Addressed feedback

Dec 13 2016, 12:29 PM
lhchavez added a reviewer for D27377: clang-format: Support the Java 8 'default' method modifier: lodato.
Dec 13 2016, 10:56 AM

Dec 9 2016

lhchavez added a comment to D27377: clang-format: Support the Java 8 'default' method modifier.

Gentle ping?

Dec 9 2016, 11:33 AM

Dec 2 2016

lhchavez retitled D27377: clang-format: Support the Java 8 'default' method modifier from to clang-format: Support the Java 8 'default' method modifier.
Dec 2 2016, 5:02 PM

Nov 3 2016

lhchavez updated subscribers of D26287: clang-format: Use git-ls-tree to get file mode in diff mode.
Nov 3 2016, 12:18 PM
lhchavez retitled D26287: clang-format: Use git-ls-tree to get file mode in diff mode from to clang-format: Use git-ls-tree to get file mode in diff mode.
Nov 3 2016, 12:16 PM

Sep 21 2016

lhchavez added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Addressed all comments. PTAAL.

Sep 21 2016, 9:01 AM · Restricted Project
lhchavez updated D24319: clang-format: Add an option to git-clang-format to diff between to commits.
Sep 21 2016, 8:59 AM · Restricted Project
lhchavez updated D24319: clang-format: Add an option to git-clang-format to diff between to commits.
Sep 21 2016, 8:59 AM · Restricted Project
lhchavez updated the diff for D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Addressed lovato's comments

Sep 21 2016, 8:57 AM · Restricted Project

Sep 19 2016

lhchavez added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Gentle ping. Is there anything else that needs addressing? Did I miss anything?

Sep 19 2016, 2:04 PM · Restricted Project

Sep 12 2016

lhchavez retitled D24319: clang-format: Add an option to git-clang-format to diff between to commits from clang-format: Add a flag to limit git-clang-format's diff to a single commit to clang-format: Add an option to git-clang-format to diff between to commits.
Sep 12 2016, 11:41 PM · Restricted Project
lhchavez updated the diff for D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Got rid of create_tree_from_commit

Sep 12 2016, 11:30 PM · Restricted Project
lhchavez added inline comments to D24319: clang-format: Add an option to git-clang-format to diff between to commits.
Sep 12 2016, 11:30 PM · Restricted Project
lhchavez updated the diff for D24401: clang-format: Add Java detection to git-clang-format..

Rebased to r281293

Sep 12 2016, 9:58 PM
lhchavez added inline comments to D24319: clang-format: Add an option to git-clang-format to diff between to commits.
Sep 12 2016, 9:17 PM · Restricted Project
lhchavez updated the diff for D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Using lodato's proposed interface. This patch:

Sep 12 2016, 9:14 PM · Restricted Project
lhchavez updated the diff for D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Fix the script so it does what it advertises.

Sep 12 2016, 6:58 PM · Restricted Project
lhchavez updated the diff for D24319: clang-format: Add an option to git-clang-format to diff between to commits.

No-op update. Using arcanist to fix the diff and the paths.

Sep 12 2016, 6:55 PM · Restricted Project
lhchavez added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

I'll post a no-op change with arcanist to fix the paths (I shouldn't have tried to manually upload the diff), and then another one to fix the patch so that the script actually does what it advertises and add the comment explaining the reason for create_tree_from_commit().

Sep 12 2016, 6:55 PM · Restricted Project
lhchavez updated the diff for D24401: clang-format: Add Java detection to git-clang-format..

Using arcanist to fix the paths as well

Sep 12 2016, 6:14 PM
lhchavez updated the diff for D24401: clang-format: Add Java detection to git-clang-format..

Generated the diff properly this time, and it now shows full context.

Sep 12 2016, 4:37 PM

Sep 9 2016

lhchavez retitled D24401: clang-format: Add Java detection to git-clang-format. from to clang-format: Add Java detection to git-clang-format..
Sep 9 2016, 8:36 AM

Sep 7 2016

lhchavez retitled D24319: clang-format: Add an option to git-clang-format to diff between to commits from to clang-format: Add a flag to limit git-clang-format's diff to a single commit.
Sep 7 2016, 3:09 PM · Restricted Project