This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Clean up MSVC support
ClosedPublic

Authored by smeenai on Sep 7 2016, 2:08 PM.

Details

Summary

Visual Studio 2013 (CRT version 12) added support for many C99 long long
and long double functions. Visual Studio 2015 (CRT version 14) increased
C99 and C11 compliance further. Since we don't support Visual Studio
versions older than 2013, we can considerably clean up the support
header.

Diff Detail

Event Timeline

smeenai updated this revision to Diff 70593.Sep 7 2016, 2:08 PM
smeenai retitled this revision from to [libc++] Clean up MSVC support.
smeenai updated this object.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
EricWF edited edge metadata.Sep 7 2016, 2:11 PM

This LGTM but I'll let @compnerd give it the final OK, since I've never built libc++ on windows.

include/support/win32/support.h
48

Maybe fold these to #if's into #if defined(_VC_CRT_MAJOR_VERSION) && _VC_CRT_MAJOR_VERSION < 14.

smeenai added inline comments.Sep 7 2016, 2:22 PM
include/support/win32/support.h
48

Good idea.

smeenai updated this revision to Diff 70598.Sep 7 2016, 2:23 PM
smeenai edited edge metadata.

Simpliying conditional per EricWF's suggestion

smeenai marked 2 inline comments as done.Sep 7 2016, 2:23 PM
compnerd accepted this revision.Sep 8 2016, 1:26 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2016, 1:26 PM
compnerd closed this revision.Sep 8 2016, 2:01 PM

SVN r280988