This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU : Add XNACK feature to GPUs that support it.
ClosedPublic

Authored by wdng on Sep 6 2016, 12:48 PM.

Download Raw Diff

Details

Reviewers

• tstellarAMD
arsenm

Group Reviewers

Restricted Project

Commits

rG5e832e866e75: AMDGPU : Add XNACK feature to GPUs that support it.
rL280742: AMDGPU : Add XNACK feature to GPUs that support it.

Summary

AMDGPU : Add XNACK feature to GPUs that support it.

Diff Detail

Repository: rL LLVM

Event Timeline

wdng updated this revision to Diff 70455.Sep 6 2016, 12:48 PM

wdng retitled this revision from to AMDGPU : Add XNACK feature to GPUs that support it..

wdng updated this object.

wdng added reviewers: • tstellarAMD, arsenm, Restricted Project.

wdng set the repository for this revision to rL LLVM.

Herald added subscribers: nhaehnle, wdng, arsenm. · View Herald TranscriptSep 6 2016, 12:48 PM

• tstellarAMD added a subscriber: llvm-commits.Sep 6 2016, 12:49 PM

LGTM. But can we also add a check that makes sure that amd_kernel_code_t's is_xnack_enabled field is 1 for carrizo and stoney?

Closed by commit rL280742: AMDGPU : Add XNACK feature to GPUs that support it. (authored by wdng). · Explain WhySep 6 2016, 1:03 PM

This revision was automatically updated to reflect the committed changes.

My bad, is_xnack_enabled is already checked

Revision Contents

Path

Size

llvm/

trunk/

lib/

Target/

AMDGPU/

Processors.td

4 lines

test/

CodeGen/

AMDGPU/

flat-scratch-reg.ll

3 lines

Diff 70460

llvm/trunk/lib/Target/AMDGPU/Processors.td

	Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Lines
	>;			>;

	def : ProcessorModel<"iceland", SIQuarterSpeedModel,			def : ProcessorModel<"iceland", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureSGPRInitBug, FeatureISAVersion8_0_0,			[FeatureVolcanicIslands, FeatureSGPRInitBug, FeatureISAVersion8_0_0,
	FeatureLDSBankCount32]			FeatureLDSBankCount32]
	>;			>;

	def : ProcessorModel<"carrizo", SIQuarterSpeedModel,			def : ProcessorModel<"carrizo", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32]			[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32, FeatureXNACK]
	>;			>;

	def : ProcessorModel<"fiji", SIQuarterSpeedModel,			def : ProcessorModel<"fiji", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureISAVersion8_0_3, FeatureLDSBankCount32]			[FeatureVolcanicIslands, FeatureISAVersion8_0_3, FeatureLDSBankCount32]
	>;			>;

	def : ProcessorModel<"stoney", SIQuarterSpeedModel,			def : ProcessorModel<"stoney", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount16]			[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount16, FeatureXNACK]
	>;			>;

	def : ProcessorModel<"polaris10", SIQuarterSpeedModel,			def : ProcessorModel<"polaris10", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32]			[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32]
	>;			>;

	def : ProcessorModel<"polaris11", SIQuarterSpeedModel,			def : ProcessorModel<"polaris11", SIQuarterSpeedModel,
	[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32]			[FeatureVolcanicIslands, FeatureISAVersion8_0_1, FeatureLDSBankCount32]
	>;			>;

llvm/trunk/test/CodeGen/AMDGPU/flat-scratch-reg.ll

	; RUN: llc -march=amdgcn -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefix=NOXNACK -check-prefix=CI -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefix=NOXNACK -check-prefix=CI -check-prefix=GCN %s
	; RUN: llc -march=amdgcn -mcpu=fiji -verify-machineinstrs < %s \| FileCheck -check-prefix=NOXNACK -check-prefix=VI -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mcpu=fiji -verify-machineinstrs < %s \| FileCheck -check-prefix=NOXNACK -check-prefix=VI -check-prefix=GCN %s
	; RUN: llc -march=amdgcn -mcpu=carrizo -mattr=+xnack -verify-machineinstrs < %s \| FileCheck -check-prefix=XNACK -check-prefix=VI -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mcpu=carrizo -verify-machineinstrs < %s \| FileCheck -check-prefix=XNACK -check-prefix=VI -check-prefix=GCN %s
				; RUN: llc -march=amdgcn -mcpu=stoney -verify-machineinstrs < %s \| FileCheck -check-prefix=XNACK -check-prefix=VI -check-prefix=GCN %s

	; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefix=CI -check-prefix=NOXNACK -check-prefix=HSA-NOXNACK -check-prefix=HSA -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=kaveri -verify-machineinstrs < %s \| FileCheck -check-prefix=CI -check-prefix=NOXNACK -check-prefix=HSA-NOXNACK -check-prefix=HSA -check-prefix=GCN %s
	; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=carrizo -mattr=-xnack -verify-machineinstrs < %s \| FileCheck -check-prefix=VI -check-prefix=NOXNACK -check-prefix=HSA-NOXNACK -check-prefix=HSA -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=carrizo -mattr=-xnack -verify-machineinstrs < %s \| FileCheck -check-prefix=VI -check-prefix=NOXNACK -check-prefix=HSA-NOXNACK -check-prefix=HSA -check-prefix=GCN %s
	; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=carrizo -mattr=+xnack -verify-machineinstrs < %s \| FileCheck -check-prefix=VI -check-prefix=XNACK -check-prefix=HSA-XNACK -check-prefix=HSA -check-prefix=GCN %s			; RUN: llc -march=amdgcn -mtriple=amdgcn--amdhsa -mcpu=carrizo -mattr=+xnack -verify-machineinstrs < %s \| FileCheck -check-prefix=VI -check-prefix=XNACK -check-prefix=HSA-XNACK -check-prefix=HSA -check-prefix=GCN %s

	; GCN-LABEL: {{^}}no_vcc_no_flat:			; GCN-LABEL: {{^}}no_vcc_no_flat:
	; HSA-NOXNACK: is_xnack_enabled = 0			; HSA-NOXNACK: is_xnack_enabled = 0
	; HSA-XNACK: is_xnack_enabled = 1			; HSA-XNACK: is_xnack_enabled = 1
	▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines