This is an archive of the discontinued LLVM Phabricator instance.

Use od instead of hexdump.
ClosedPublic

Authored by ruiu on Sep 2 2016, 1:19 PM.

Download Raw Diff

Details

Reviewers

• tstellarAMD
grimar

Commits

rGb397ab5895a8: Use od instead of hexdump.
rLLD280536: Use od instead of hexdump.
rL280536: Use od instead of hexdump.

Summary

od is defined by POSIX and exists since version 1 AT&T Unix.
hexdump is not part of any standard as far as I know.
So od is a better choice than hexdump.

Diff Detail

Repository: rL LLVM

Event Timeline

ruiu updated this revision to Diff 70217.Sep 2 2016, 1:19 PM

ruiu retitled this revision from to Use od instead of hexdump..

ruiu updated this object.

ruiu added reviewers: grimar, • tstellarAMD.

ruiu added a subscriber: llvm-commits.

Herald added a subscriber: wdng. · View Herald TranscriptSep 2 2016, 1:19 PM

lgtm assuming it's available on windows as well (as part of wingnu32)

Works for me on windows. I am using GnuWin32.

This revision is now accepted and ready to land.Sep 2 2016, 1:23 PM

Closed by commit rL280536: Use od instead of hexdump. (authored by ruiu). · Explain WhySep 2 2016, 1:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lld/

trunk/

test/

ELF/

oformat-binary.s

6 lines

Diff 70219

lld/trunk/test/ELF/oformat-binary.s

	# REQUIRES: x86			# REQUIRES: x86
	# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t			# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t

	# RUN: ld.lld -o %t.out %t --oformat binary			# RUN: ld.lld -o %t.out %t --oformat binary
	# RUN: hexdump -C %t.out \| FileCheck %s			# RUN: od -t x1 -v %t.out \| FileCheck %s
	# CHECK: 00000000 90 11 22 00 00 00 00 00			# CHECK: 000000 90 11 22 00 00 00 00 00
	# CHECK-NOT: 00000010			# CHECK-NOT: 00000010

	## Check case when linkerscript is used.			## Check case when linkerscript is used.
	# RUN: echo "SECTIONS { . = 0x1000; }" > %t.script			# RUN: echo "SECTIONS { . = 0x1000; }" > %t.script
	# RUN: ld.lld -o %t2.out --script %t.script %t --oformat binary			# RUN: ld.lld -o %t2.out --script %t.script %t --oformat binary
	# RUN: hexdump -C %t2.out \| FileCheck %s			# RUN: od -t x1 -v %t2.out \| FileCheck %s

	# RUN: not ld.lld -o %t3.out %t --oformat foo 2>&1 \			# RUN: not ld.lld -o %t3.out %t --oformat foo 2>&1 \
	# RUN: \| FileCheck %s --check-prefix ERR			# RUN: \| FileCheck %s --check-prefix ERR
	# ERR: unknown --oformat value: foo			# ERR: unknown --oformat value: foo

	.text			.text
	.align 4			.align 4
	.globl _start			.globl _start
	_start:			_start:
	nop			nop

	.section .mysec.1,"ax"			.section .mysec.1,"ax"
	.byte 0x11			.byte 0x11

	.section .mysec.2,"ax"			.section .mysec.2,"ax"
	.byte 0x22			.byte 0x22