This is an archive of the discontinued LLVM Phabricator instance.

[LLVM/Support] - Create no-arguments constructor for llvm::Regex
ClosedPublic

Authored by grimar on Aug 31 2016, 2:18 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 69901.Aug 31 2016, 2:18 PM
grimar retitled this revision from to [LLVM/Support] - Create no-arguments constructor for llvm::Regex.
grimar updated this object.
grimar added reviewers: rafael, dblaikie, ruiu, davide.
grimar added subscribers: llvm-commits, grimar.
ruiu accepted this revision.Aug 31 2016, 2:39 PM
ruiu edited edge metadata.

Ah, OK. LGTM. But you want to wait for someone who have contributed to this code.

This revision is now accepted and ready to land.Aug 31 2016, 2:39 PM
dblaikie accepted this revision.Aug 31 2016, 3:45 PM
dblaikie edited edge metadata.

Looks good - please commit.

This revision was automatically updated to reflect the committed changes.