This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Don't add -fPIC on Windows
ClosedPublic

Authored by smeenai on Aug 31 2016, 1:33 PM.

Reviewers

Summary

-fPIC doesn't make much sense for Windows, since Windows DLLs aren't
compiled position independent and are instead relocated at runtime.

smeenai retitled this revision from to [libc++] Don't add -fPIC on Windows.

smeenai updated this object.

smeenai added a subscriber: cfe-commits.

LGTM.

This revision is now accepted and ready to land.Sep 1 2016, 11:22 AM

SVN r280413

Path

Size

lib/

4 lines

	Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines
	add_library_flags_if(LIBCXX_HAS_PTHREAD_LIB pthread)			add_library_flags_if(LIBCXX_HAS_PTHREAD_LIB pthread)
	add_library_flags_if(LIBCXX_HAS_C_LIB c)			add_library_flags_if(LIBCXX_HAS_C_LIB c)
	add_library_flags_if(LIBCXX_HAS_M_LIB m)			add_library_flags_if(LIBCXX_HAS_M_LIB m)
	add_library_flags_if(LIBCXX_HAS_RT_LIB rt)			add_library_flags_if(LIBCXX_HAS_RT_LIB rt)
	add_library_flags_if(LIBCXX_HAS_GCC_S_LIB gcc_s)			add_library_flags_if(LIBCXX_HAS_GCC_S_LIB gcc_s)
	add_library_flags_if(LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB atomic)			add_library_flags_if(LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB atomic)

	# Setup flags.			# Setup flags.
				if (NOT WIN32)
	add_flags_if_supported(-fPIC)			add_flags_if_supported(-fPIC)
				endif()
	add_link_flags_if_supported(-nodefaultlibs)			add_link_flags_if_supported(-nodefaultlibs)

	if ( APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR			if ( APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
	LIBCXX_CXX_ABI_LIBNAME STREQUAL "none"))			LIBCXX_CXX_ABI_LIBNAME STREQUAL "none"))
	if (NOT DEFINED LIBCXX_LIBCPPABI_VERSION)			if (NOT DEFINED LIBCXX_LIBCPPABI_VERSION)
	set(LIBCXX_LIBCPPABI_VERSION "2") # Default value			set(LIBCXX_LIBCPPABI_VERSION "2") # Default value
	execute_process(			execute_process(
	COMMAND xcrun --show-sdk-version			COMMAND xcrun --show-sdk-version
	▲ Show 20 Lines • Show All 178 Lines • Show Last 20 Lines