[lit] Allow more file extensions for test cases.

[logan]

Summary

This commit splits the file extensions before determining the test
format. This allows libc++abi to add assembly-based test cases.

[EricWF]

I don't think assembly based .pass and .fail tests will work quite yet. The CXXCompiler object used by the test format explicitly passes -xc++ %s in some cases.
I'm assuming you already have a libc++abi assembly test? Could you put it up for review?

[EricWF]

Woops I see the test case now. LGTM.

test/libcxx/test/format.py

69

Since we only support .sh.XXX tests let's only loosen the restriction there for now.

[logan]

test/libcxx/test/format.py

69

Do you mean that it is preferred to revert following two lines back? For example:

is_sh_test = name_root.endswith('.sh')
is_pass_test = name.endswith('.pass.cpp')
is_fail_test = name.endswith('.fail.cpp')
assert is_sh_test or name_ext == '.cpp'

[EricWF]

test/libcxx/test/format.py

69

Yeah. Leave a FIXME about CXXCompiler not supporting assembly if you want.

[logan]

Thanks for reviewing. Committed as rL283118 with the suggested change regarding to is_sh_test assertion.

test/libcxx/test/format.py

def execute(self, test, lit_config):
                 return self._execute(test, lit_config)
             except OSError as oe:
                 if oe.errno != errno.ETXTBSY:
                     raise
                 time.sleep(0.1)
 
     def _execute(self, test, lit_config):
         name = test.path_in_suite[-1]
-        is_sh_test = name.endswith('.sh.cpp')
-        is_pass_test = name.endswith('.pass.cpp')
-        is_fail_test = name.endswith('.fail.cpp')
+        name_root, name_ext = os.path.splitext(name)
+        is_sh_test = name_root.endswith('.sh')
+        is_pass_test = name_root.endswith('.pass')
+        is_fail_test = name_root.endswith('.fail')
 
         if test.config.unsupported:
             return (lit.Test.UNSUPPORTED,
                     "A lit.local.cfg marked this unsupported")
 
         script = lit.TestRunner.parseIntegratedTestScript(
             test, require_script=is_sh_test)
         # Check if a result for the test was returned. If so return that