This is an archive of the discontinued LLVM Phabricator instance.

[lit] Replace print with lit_config.note().
ClosedPublic

Authored by logan on Aug 31 2016, 8:37 AM.

Download Raw Diff

Details

Reviewers

mclow.lists
rengolin
EricWF

Summary

This commit replaces print statement with lit_config.note(). This fixes
python3 support for check-libcxxabi.

Diff Detail

Event Timeline

logan updated this revision to Diff 69858.Aug 31 2016, 8:37 AM

logan retitled this revision from to [lit] Replace print with lit_config.note()..

logan updated this object.

logan added reviewers: mclow.lists, rengolin, EricWF.

logan added a subscriber: cfe-commits.

EricWF accepted this revision.Aug 31 2016, 9:57 PM

EricWF edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2016, 9:57 PM

Thanks. Committed as rL280484.

logan closed this revision.Sep 2 2016, 7:05 AM

Revision Contents

Path

Size

test/

lit.cfg

2 lines

Diff 69858

test/lit.cfg

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines	if obj_root is None:
obj_root = tempfile.mkdtemp(prefix='libcxxabi-testsuite-')		obj_root = tempfile.mkdtemp(prefix='libcxxabi-testsuite-')
lit_config.warning('Creating temporary directory for object root: %s' %		lit_config.warning('Creating temporary directory for object root: %s' %
obj_root)		obj_root)

config.test_exec_root = os.path.join(obj_root, 'test')		config.test_exec_root = os.path.join(obj_root, 'test')

cfg_variant = getattr(config, 'configuration_variant', 'libcxxabi')		cfg_variant = getattr(config, 'configuration_variant', 'libcxxabi')
if cfg_variant:		if cfg_variant:
print 'Using configuration variant: %s' % cfg_variant		lit_config.note('Using configuration variant: %s' % cfg_variant)

# Load the Configuration class from the module name <cfg_variant>.test.config.		# Load the Configuration class from the module name <cfg_variant>.test.config.
config_module_name = '.'.join([cfg_variant, 'test', 'config'])		config_module_name = '.'.join([cfg_variant, 'test', 'config'])
config_module = __import__(config_module_name, fromlist=['Configuration'])		config_module = __import__(config_module_name, fromlist=['Configuration'])

configuration = config_module.Configuration(lit_config, config)		configuration = config_module.Configuration(lit_config, config)
configuration.configure()		configuration.configure()
configuration.print_config_info()		configuration.print_config_info()
config.test_format = configuration.get_test_format()		config.test_format = configuration.get_test_format()