Page MenuHomePhabricator

Disable the common parts for the sanitizer tools on kfreebsd
AbandonedPublic

Authored by sylvestre.ledru on Aug 28 2016, 2:16 PM.

Details

Reviewers
kcc
beanz
Summary

Patch by Pino Toscano. Reported in http://bugs.debian.org/835665

Diff Detail

Event Timeline

sylvestre.ledru retitled this revision from to Disable the common parts for the sanitizer tools on kfreebsd.
sylvestre.ledru updated this object.
sylvestre.ledru added a reviewer: beanz.
kcc edited edge metadata.Mar 1 2017, 12:44 PM

I'd like someone from the *FreeBSD crowd to review.
(Also, please look into making the condition more readable.. the cmake syntax doesn't help here)

Hi! I'm the original author of this patch.

In D23976#689934, @kcc wrote:

I'd like someone from the *FreeBSD crowd to review.
(Also, please look into making the condition more readable.. the cmake syntax doesn't help here)

What would you suggest regarding the cmake syntax? It looks readable to me already, but of course I'm happy to improve it to make it even more readable.

@kcc Do you know who could review that? Thanks

kcc added a comment.Jul 10 2017, 5:50 PM

@kcc Do you know who could review that? Thanks

Not off the top of my head, but if you CC this to llvm-commits it's likely that someone from *FreeBSD will reply.
Looking again at the code: I think it's actually ok.

sylvestre.ledru abandoned this revision.Jan 16 2019, 11:52 PM

fixed I think