This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Make is_valid_event, create_user_event overloadable.
ClosedPublic

Authored by etyurin on Aug 26 2016, 2:12 AM.

Download Raw Diff

Details

Reviewers

yaxunl
bader

Commits

rGb5d90e57dcbb: [OpenCL] Make is_valid_event, create_user_event overloadable.
rC280097: [OpenCL] Make is_valid_event, create_user_event overloadable.
rL280097: [OpenCL] Make is_valid_event, create_user_event overloadable.

Summary

Make is_valid_event and create_user_event overloadable like other built-ins.

Diff Detail

Event Timeline

etyurin updated this revision to Diff 69328.Aug 26 2016, 2:12 AM

etyurin retitled this revision from to [OpenCL] Make is_valid_event overloadable..

etyurin updated this object.

etyurin added reviewers: yaxunl, bader.

etyurin added subscribers: cfe-commits, Anastasia.

LGTM

This revision is now accepted and ready to land.Aug 26 2016, 2:47 AM

yaxunl added inline comments.Aug 28 2016, 8:58 AM

lib/Headers/opencl-c.h
16732	can we also make this one __ovld? Thanks.

Applied comment from Sam.

LGTM. Thanks.

Closed by commit rL280097: [OpenCL] Make is_valid_event, create_user_event overloadable. (authored by bader). · Explain WhyAug 30 2016, 7:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Headers/

opencl-c.h

4 lines

Diff 69650

lib/Headers/opencl-c.h

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 16,723 Lines • ▼ Show 20 Lines
	ndrange_t __ovld ndrange_3D(const size_t[3], const size_t[3], const size_t[3]);			ndrange_t __ovld ndrange_3D(const size_t[3], const size_t[3], const size_t[3]);

	int __ovld enqueue_marker(queue_t, uint, const __private clk_event_t, __private clk_event_t);			int __ovld enqueue_marker(queue_t, uint, const __private clk_event_t, __private clk_event_t);

	void __ovld retain_event(clk_event_t);			void __ovld retain_event(clk_event_t);

	void __ovld release_event(clk_event_t);			void __ovld release_event(clk_event_t);

	clk_event_t create_user_event(void);			clk_event_t __ovld create_user_event(void);
				yaxunlUnsubmitted Not Done Reply Inline Actions can we also make this one __ovld? Thanks. yaxunl: can we also make this one __ovld? Thanks.

	void __ovld set_user_event_status(clk_event_t e, int state);			void __ovld set_user_event_status(clk_event_t e, int state);

	bool is_valid_event (clk_event_t event);			bool __ovld is_valid_event (clk_event_t event);

	void __ovld capture_event_profiling_info(clk_event_t, clk_profiling_info, __global void* value);			void __ovld capture_event_profiling_info(clk_event_t, clk_profiling_info, __global void* value);

	queue_t __ovld get_default_queue(void);			queue_t __ovld get_default_queue(void);
	#endif //__OPENCL_C_VERSION__ >= CL_VERSION_2_0			#endif //__OPENCL_C_VERSION__ >= CL_VERSION_2_0

	// OpenCL Extension v2.0 s9.17 - Sub-groups			// OpenCL Extension v2.0 s9.17 - Sub-groups

	▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines