This is an archive of the discontinued LLVM Phabricator instance.

Differential D23709

[asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas
ClosedPublic

Authored by vitalybuka on Aug 19 2016, 1:43 AM.

Details

Reviewers
eugenis
Commits
rG8176ee9b5dda: [asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas
rCRT279377: [asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas
rL279377: [asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas
Summary

Depends on D23707.

Diff Detail

Event Timeline

vitalybuka updated this revision to Diff 68660.Aug 19 2016, 1:43 AM
vitalybuka retitled this revision from to [asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas.
vitalybuka updated this object.
vitalybuka added a parent revision: D23707: [asan] Cleanup instrumentation of dynamic allocas.
Herald added a subscriber: kubamracek. · View Herald TranscriptAug 19 2016, 1:43 AM
vitalybuka added a reviewer: eugenis.Aug 19 2016, 11:48 AM
vitalybuka added a subscriber: llvm-commits.
eugenis accepted this revision.Aug 19 2016, 12:26 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 19 2016, 12:26 PM
Closed by commit rL279377: [asan] Rename asan-instrument-allocas -> asan-instrument-dynamic-allocas (authored by vitalybuka). · Explain WhyAug 20 2016, 10:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 68660

test/asan/TestCases/alloca_big_alignment.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(128))); volatile char str[len] __attribute__((aligned(128)));
assert(!(reinterpret_cast<long>(str) & 127L)); assert(!(reinterpret_cast<long>(str) & 127L));
Show All 9 Lines

test/asan/TestCases/alloca_detect_custom_size_.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
#include <assert.h> #include <assert.h>
struct A { struct A {
char a[3]; char a[3];
int b[3]; int b[3];
Show All 14 Lines

test/asan/TestCases/alloca_instruments_all_paddings.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: %clangxx_asan -O3 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O3 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: %run %t 2>&1 // RUN: %run %t 2>&1
// //
#include "sanitizer/asan_interface.h" #include "sanitizer/asan_interface.h"
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(32))); volatile char str[len] __attribute__((aligned(32)));
Show All 14 Lines

test/asan/TestCases/alloca_loop_unpoisoning.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: %run %t 2>&1 // RUN: %run %t 2>&1
// //
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
// This testcase checks that allocas and VLAs inside loop are correctly unpoisoned. // This testcase checks that allocas and VLAs inside loop are correctly unpoisoned.
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
Show All 29 Lines

test/asan/TestCases/alloca_overflow_partial.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(32))); volatile char str[len] __attribute__((aligned(32)));
assert(!(reinterpret_cast<long>(str) & 31L)); assert(!(reinterpret_cast<long>(str) & 31L));
Show All 9 Lines

test/asan/TestCases/alloca_overflow_right.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(32))); volatile char str[len] __attribute__((aligned(32)));
assert(!(reinterpret_cast<long>(str) & 31L)); assert(!(reinterpret_cast<long>(str) & 31L));
Show All 9 Lines

test/asan/TestCases/alloca_safe_access.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: %run %t 2>&1 // RUN: %run %t 2>&1
// //
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(32))); volatile char str[len] __attribute__((aligned(32)));
assert(!(reinterpret_cast<long>(str) & 31L)); assert(!(reinterpret_cast<long>(str) & 31L));
str[index] = '1'; str[index] = '1';
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {
foo(4, 5); foo(4, 5);
foo(39, 40); foo(39, 40);
return 0; return 0;
} }

test/asan/TestCases/alloca_underflow_left.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
#include <assert.h> #include <assert.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
volatile char str[len] __attribute__((aligned(32))); volatile char str[len] __attribute__((aligned(32)));
assert(!(reinterpret_cast<long>(str) & 31L)); assert(!(reinterpret_cast<long>(str) & 31L));
Show All 9 Lines

test/asan/TestCases/alloca_vla_interact.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: %run %t 2>&1 // RUN: %run %t 2>&1
// //
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
// This testcase checks correct interaction between VLAs and allocas. // This testcase checks correct interaction between VLAs and allocas.
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
Show All 36 Lines

test/asan/TestCases/vla_chrome_testcase.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
// This is reduced testcase based on Chromium code. // This is reduced testcase based on Chromium code.
// See http://reviews.llvm.org/D6055?vs=on&id=15616&whitespace=ignore-all#toc. // See http://reviews.llvm.org/D6055?vs=on&id=15616&whitespace=ignore-all#toc.
#include <stdint.h> #include <stdint.h>
#include <assert.h> #include <assert.h>
Show All 21 Lines

test/asan/TestCases/vla_condition_overflow.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
__attribute__((noinline)) void foo(int index, int len) { __attribute__((noinline)) void foo(int index, int len) {
Show All 13 Lines

test/asan/TestCases/vla_loop_overfow.cc

// RUN: %clangxx_asan -O0 -mllvm -asan-instrument-allocas %s -o %t // RUN: %clangxx_asan -O0 -mllvm -asan-instrument-dynamic-allocas %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// //
// REQUIRES: stable-runtime // REQUIRES: stable-runtime
#include <assert.h> #include <assert.h>
#include <stdint.h> #include <stdint.h>
void foo(int index, int len) { void foo(int index, int len) {
Show All 13 Lines