This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings
ClosedPublic

Authored by Eugene.Zelenko on Aug 18 2016, 10:16 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings.
Eugene.Zelenko updated this object.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: llvm-commits.
mehdi_amini edited edge metadata.Aug 18 2016, 10:33 AM

Thanks for the cleanup, please keep the habit of uploading with context, it helps :)

include/llvm/Bitcode/BitstreamReader.h
33

Can you confirm: all these extra headers are for things needed by the current header but are included transitively right now?

I'll try to not forget to include full diff. However, I don't understand why Differential could not do this itself. After all base version is included into diff :-)

include/llvm/Bitcode/BitstreamReader.h
33

Yes, all added headers are really used. I always check IWYU warnings manually.

mehdi_amini accepted this revision.Aug 18 2016, 10:41 AM
mehdi_amini edited edge metadata.

LGTM then!

This revision is now accepted and ready to land.Aug 18 2016, 10:41 AM
This revision was automatically updated to reflect the committed changes.