This is an archive of the discontinued LLVM Phabricator instance.

Differential D23641

[ASTMatchers] Fix documentation of is(Un)SignedInteger()
ClosedPublic

Authored by thegameg on Aug 17 2016, 7:51 PM.

Details

Reviewers
aaron.ballman
courbet
Summary

The example is using isInteger() instead of signed / unsigned version.

Diff Detail

Event Timeline

thegameg updated this revision to Diff 68476.Aug 17 2016, 7:51 PM
thegameg retitled this revision from to [ASTMatchers] Fix documentation of is(Un)SignedInteger().
thegameg updated this object.
thegameg added reviewers: aaron.ballman, courbet.
thegameg added a subscriber: cfe-commits.
Herald added a subscriber: klimek. · View Herald TranscriptAug 17 2016, 7:51 PM
aaron.ballman accepted this revision.Aug 18 2016, 5:22 AM
aaron.ballman edited edge metadata.

LGTM, thank you!

This revision is now accepted and ready to land.Aug 18 2016, 5:22 AM
thegameg added a comment.Aug 18 2016, 5:27 AM

Can you commit this for me, please? Thanks!

aaron.ballman closed this revision.Aug 18 2016, 5:34 AM

Commit in r279055

courbet edited edge metadata.Aug 23 2016, 2:59 AM

Thanks.

Revision Contents

PathSize
docs/
4 lines
include/
clang/
ASTMatchers/
4 lines

Diff 68476

docs/LibASTMatchersReference.html

Context not available.
void a(int); void a(int);
void b(unsigned long); void b(unsigned long);
void c(double); void c(double);
functionDecl(hasAnyParameter(hasType(isInteger()))) functionDecl(hasAnyParameter(hasType(isSignedInteger())))
matches "a(int)", but not "b(unsigned long)" and "c(double)". matches "a(int)", but not "b(unsigned long)" and "c(double)".
</pre></td></tr> </pre></td></tr>
Context not available.
void a(int); void a(int);
void b(unsigned long); void b(unsigned long);
void c(double); void c(double);
functionDecl(hasAnyParameter(hasType(isInteger()))) functionDecl(hasAnyParameter(hasType(isUnsignedInteger())))
matches "b(unsigned long)", but not "a(int)" and "c(double)". matches "b(unsigned long)", but not "a(int)" and "c(double)".
</pre></td></tr> </pre></td></tr>
Context not available.

include/clang/ASTMatchers/ASTMatchers.h

Context not available.
/// void b(unsigned long); /// void b(unsigned long);
/// void c(double); /// void c(double);
/// \endcode /// \endcode
/// functionDecl(hasAnyParameter(hasType(isInteger()))) /// functionDecl(hasAnyParameter(hasType(isUnsignedInteger())))
/// matches "b(unsigned long)", but not "a(int)" and "c(double)". /// matches "b(unsigned long)", but not "a(int)" and "c(double)".
AST_MATCHER(QualType, isUnsignedInteger) { AST_MATCHER(QualType, isUnsignedInteger) {
return Node->isUnsignedIntegerType(); return Node->isUnsignedIntegerType();
Context not available.
/// void b(unsigned long); /// void b(unsigned long);
/// void c(double); /// void c(double);
/// \endcode /// \endcode
/// functionDecl(hasAnyParameter(hasType(isInteger()))) /// functionDecl(hasAnyParameter(hasType(isSignedInteger())))
/// matches "a(int)", but not "b(unsigned long)" and "c(double)". /// matches "a(int)", but not "b(unsigned long)" and "c(double)".
AST_MATCHER(QualType, isSignedInteger) { AST_MATCHER(QualType, isSignedInteger) {
return Node->isSignedIntegerType(); return Node->isSignedIntegerType();
Context not available.