This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target
ClosedPublic

Authored by iid_iunknown on Aug 17 2016, 4:03 PM.

Details

Summary

test/builtins/Unit/cpu_model_test.c tests the X86 specific builtin __builtin_cpu_supports.
It fails if the clang's default target is not X86.

The proposed patch adds an additional requirement for the X86 target to the test, making lit ignore the test if the target is different.

Diff Detail

Repository
rL LLVM

Event Timeline

iid_iunknown retitled this revision from to [compiler-rt][tests] cpu_model_test.c test fails to compile if X86 is not clang's default target.
iid_iunknown updated this object.
iid_iunknown added a reviewer: asbirlea.
iid_iunknown set the repository for this revision to rL LLVM.
iid_iunknown added a subscriber: llvm-commits.
asbirlea accepted this revision.Aug 17 2016, 4:44 PM
asbirlea edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 17 2016, 4:44 PM

Thank you for the review, Alina.

iid_iunknown closed this revision.Aug 18 2016, 7:47 AM