This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix instruction flags for s_endpgm
ClosedPublic

Authored by arsenm on Aug 16 2016, 12:25 PM.

Details

Summary

Set isReturn, remove hasSideEffects. Also remove hasCtrlDep, I'm not really sure what that does.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 68239.Aug 16 2016, 12:25 PM
arsenm retitled this revision from to AMDGPU: Fix instruction flags for s_endpgm.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.

This requires disabling requiring structured CFG to fix a test regression from the post-RA tail duplication pass not running

nhaehnle accepted this revision.Sep 3 2016, 5:48 AM
nhaehnle added a reviewer: nhaehnle.
nhaehnle added a subscriber: nhaehnle.

LGTM, given D23584.

This revision is now accepted and ready to land.Sep 3 2016, 5:48 AM
arsenm closed this revision.Oct 28 2016, 4:10 PM

r285476