This is an archive of the discontinued LLVM Phabricator instance.

[Basic] Add missing `const` qualifier (NFC)
ClosedPublic

Authored by thegameg on Aug 11 2016, 3:47 PM.

Reviewers

Commits

Summary

The member function is a predicate, and doesn't apply any changes on the object.

thegameg retitled this revision from to [Basic] Add missing `const` qualifier (NFC).

thegameg updated this object.

thegameg added a subscriber: cfe-commits.

Makes sense. isMacroID and isInSystemHeader are both already marked const.

This revision is now accepted and ready to land.Aug 11 2016, 3:49 PM

Thanks @vsk. As I don't have commit access, is it possible to commit this for me, please? Thanks.

This revision was automatically updated to reflect the committed changes.

Path

Size

include/

clang/

Basic/

2 lines

Context not available.
	}	}

	/// \brief Returns whether \p Loc is expanded from a macro in a system header.	/// \brief Returns whether \p Loc is expanded from a macro in a system header.
	bool isInSystemMacro(SourceLocation loc) {	bool isInSystemMacro(SourceLocation loc) const {
	return loc.isMacroID() && isInSystemHeader(getSpellingLoc(loc));	return loc.isMacroID() && isInSystemHeader(getSpellingLoc(loc));
	}	}

Context not available.