Page MenuHomePhabricator

Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions
ClosedPublic

Authored by omjavaid on Aug 11 2016, 2:42 AM.

Details

Summary

LldbGdbServerTestCase.test_software_breakpoint_set* are failing when breakpoint target address is an thumb16 instruction.

Test right now doesnt handle thumb mode which means that it should only be built in arm mode using -marm flag in gcc.

This patch makes sure that we are building this test in arm mode.

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 67663.Aug 11 2016, 2:42 AM
omjavaid retitled this revision from to Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions.
omjavaid updated this object.
omjavaid added a reviewer: labath.
omjavaid added a subscriber: lldb-commits.
labath accepted this revision.Aug 11 2016, 3:28 AM
labath edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2016, 3:28 AM
This revision was automatically updated to reflect the committed changes.