This is an archive of the discontinued LLVM Phabricator instance.

AArch64: Assert on analyzeBranch failing
ClosedPublic

Authored by arsenm on Aug 10 2016, 3:20 PM.

Reviewers

t.p.northover

arsenm retitled this revision from to AArch64: Assert on analyzeBranch failing.

arsenm updated this object.

arsenm added a subscriber: llvm-commits.

Looks fine to me.

This revision is now accepted and ready to land.Aug 11 2016, 9:37 AM

r278366

Path

Size

lib/

Target/

AArch64/

4 lines

Show First 20 Lines • Show All 420 Lines • ▼ Show 20 Lines	if (std::next(MachineBasicBlock::iterator(MI)) ==
}		}
}		}
}		}

if (NeedSplit) {		if (NeedSplit) {
// Analyze the branch so we know how to update the successor lists.		// Analyze the branch so we know how to update the successor lists.
MachineBasicBlock TBB, FBB;		MachineBasicBlock TBB, FBB;
SmallVector<MachineOperand, 2> Cond;		SmallVector<MachineOperand, 2> Cond;
TII->analyzeBranch(*MBB, TBB, FBB, Cond, false);		bool Fail = TII->analyzeBranch(*MBB, TBB, FBB, Cond, false);
		assert(!Fail && "branches to relax should be analyzable");
		(void)Fail;

MachineBasicBlock *NewBB = splitBlockBeforeInstr(MI);		MachineBasicBlock *NewBB = splitBlockBeforeInstr(MI);
// No need for the branch to the next block. We're adding an unconditional		// No need for the branch to the next block. We're adding an unconditional
// branch to the destination.		// branch to the destination.
int delta = TII->getInstSizeInBytes(MBB->back());		int delta = TII->getInstSizeInBytes(MBB->back());
BlockInfo[MBB->getNumber()].Size -= delta;		BlockInfo[MBB->getNumber()].Size -= delta;
MBB->back().eraseFromParent();		MBB->back().eraseFromParent();
// BlockInfo[SplitBB].Offset is wrong temporarily, fixed below		// BlockInfo[SplitBB].Offset is wrong temporarily, fixed below
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines