This is an archive of the discontinued LLVM Phabricator instance.

[OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams
ClosedPublic

Authored by protze.joachim on Aug 9 2016, 4:03 AM.

Details

Summary

The comment already states, that this function should work similarly as __ompt_get_taskinfo.

The function only looked for lwt entries of the current team, but not when unrolling the parents. This fix aligns the implementation to __ompt_get_taskinfo.

The new test case creates a single theaded team (->lwt) and then a nested active team.
Before the innermost print_id(1) would deliver a different team then the outer print_id(0).

Diff Detail

Repository
rL LLVM

Event Timeline

protze.joachim retitled this revision from to [OMPT] fix __ompt_get_teaminfo to consult lwt entries of parent teams.
protze.joachim updated this object.
Hahnfeld resigned from this revision.Aug 19 2016, 12:16 AM
Hahnfeld edited reviewers, added: omalyshe; removed: Hahnfeld.

LGTM from an OMPT perspective

AndreyChurbanov accepted this revision.Aug 19 2016, 6:31 AM
AndreyChurbanov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 19 2016, 6:31 AM
jlpeyton accepted this revision.Aug 19 2016, 2:47 PM
jlpeyton edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.