[analyzer][Rewrite] Fix boxes and shadows in HTML rewrites in Firefox.

[NoQ]

Summary

Use the official CSS3 properties border-radius and box-shadow (not only -webkit-specific properties).

Fixes analyzer's diagnostic pieces in HTML diagnostics mode in Firefox and other non-webkit browsers.

Before:

before.html5 KBDownload

After:

after.html5 KBDownload

Not sure, do we need more reviewers? - it seems that HTMLRewrite is mostly used in the analyzer. Also, are there html/css gurus around? Cause the best thing i can do is trust the "a lot of green boxes" feeling at http://caniuse.com/#feat=border-radius and http://caniuse.com/#feat=css-boxshadow :)

[a.sidorin]

lib/Rewrite/HTMLRewrite.cpp

304 ↗

(On Diff #67182)

Should we remove '-webkit'-prefixed options as well? AFAIR, non-prefixed options should be supported by Webkit. Could you check with Chrome/Safari?

[NoQ]

lib/Rewrite/HTMLRewrite.cpp

304 ↗

(On Diff #67182)

All modern browsers should support the unprefixed property and work well without the prefixed property, but i'm not sure if there ever existed older browsers that used to support only the prefixed property. So i think i'm playing safe.

Also, i read that they recommend putting prefixed properties before unprefixed, because prefixed properties should override unprefixed properties whenever supported; i'd fix that.

cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

os << "<style type=\"text/css\">\n"
       " .keyword { color: blue }\n"
       " .string_literal { color: red }\n"
       " .directive { color: darkmagenta }\n"
       // Macro expansions.
       " .expansion { display: none; }\n"
       " .macro:hover .expansion { display: block; border: 2px solid #FF0000; "
           "padding: 2px; background-color:#FFF0F0; font-weight: normal; "
           "  -webkit-border-radius:5px;  -webkit-box-shadow:1px 1px 7px #000; "
+          "  border-radius:5px;  box-shadow:1px 1px 7px #000; "
           "position: absolute; top: -1em; left:10em; z-index: 1 } \n"
       " .macro { color: darkmagenta; background-color:LemonChiffon;"
              // Macros are position: relative to provide base for expansions.
              " position: relative }\n"
       " .num { width:2.5em; padding-right:2ex; background-color:#eeeeee }\n"
       " .num { text-align:right; font-size:8pt }\n"
       " .num { color:#444444 }\n"
       " .line { padding-left: 1ex; border-left: 3px solid #ccc }\n"
       " .line { white-space: pre }\n"
       " .msg { -webkit-box-shadow:1px 1px 7px #000 }\n"
+      " .msg { box-shadow:1px 1px 7px #000 }\n"
       " .msg { -webkit-border-radius:5px }\n"
+      " .msg { border-radius:5px }\n"
       " .msg { font-family:Helvetica, sans-serif; font-size:8pt }\n"
       " .msg { float:left }\n"
       " .msg { padding:0.25em 1ex 0.25em 1ex }\n"
       " .msg { margin-top:10px; margin-bottom:10px }\n"
       " .msg { font-weight:bold }\n"
       " .msg { max-width:60em; word-wrap: break-word; white-space: pre-wrap }\n"
       " .msgT { padding:0x; spacing:0x }\n"
       " .msgEvent { background-color:#fff8b4; color:#000000 }\n"
       " .msgControl { background-color:#bbbbbb; color:#000000 }\n"
       " .mrange { background-color:#dfddf3 }\n"
       " .mrange { border-bottom:1px solid #6F9DBE }\n"
       " .PathIndex { font-weight: bold; padding:0px 5px; "
         "margin-right:5px; }\n"
       " .PathIndex { -webkit-border-radius:8px }\n"
+      " .PathIndex { border-radius:8px }\n"
       " .PathIndexEvent { background-color:#bfba87 }\n"
       " .PathIndexControl { background-color:#8c8c8c }\n"
       " .PathNav a { text-decoration:none; font-size: larger }\n"
       " .CodeInsertionHint { font-weight: bold; background-color: #10dd10 }\n"
       " .CodeRemovalHint { background-color:#de1010 }\n"
       " .CodeRemovalHint { border-bottom:1px solid #6F9DBE }\n"
       " table.simpletable {\n"
       "   padding: 5px;\n"