Page MenuHomePhabricator

[AArch64] PR28877: Don't assume we're running after legalization when creating vcvtfp2fxs
ClosedPublic

Authored by sbaranga on Aug 8 2016, 5:57 AM.

Details

Summary

The DAG combine transformation that was generating the
aarch64_neon_vcvtfp2fxs node was assuming that all
inputs where legal and wasn't accounting that the input
could be a v4f64 if we're trying to do the transformation
before legalization. We now bail out in this case.

All illegal types besides v4f64 were already rejected.

Fixes https://llvm.org/bugs/show_bug.cgi?id=28877.

Diff Detail

Event Timeline

sbaranga updated this revision to Diff 67150.Aug 8 2016, 5:57 AM
sbaranga retitled this revision from to [AArch64] Don't assume we're running after legalization when creating vcvtfp2fxs.
sbaranga updated this object.
sbaranga added a reviewer: jmolloy.
sbaranga added a subscriber: llvm-commits.
jmolloy accepted this revision.Aug 8 2016, 5:59 AM
jmolloy edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Aug 8 2016, 5:59 AM
sbaranga retitled this revision from [AArch64] Don't assume we're running after legalization when creating vcvtfp2fxs to [AArch64] PR28877: Don't assume we're running after legalization when creating vcvtfp2fxs.Aug 8 2016, 6:00 AM
sbaranga updated this object.
sbaranga edited edge metadata.
sbaranga closed this revision.Aug 8 2016, 6:21 AM

Thanks, James! Committed in r278002.