This is an archive of the discontinued LLVM Phabricator instance.

asan/win: Disable a few tests that fail on bots with not a lot of memory.
ClosedPublic

Authored by thakis on Aug 5 2016, 3:26 PM.

Details

Reviewers
etienneb
rnk
Summary

This is very ad-hoc: I just disabled all tests that failed in three runs on some of our Windows bots. Is there some general pattern that matches the tests I'm disabling, and do other tests match that pattern too? Put differently: Are there other similar tests in this file I should disable?

Diff Detail

Event Timeline

thakis updated this revision to Diff 67036.Aug 5 2016, 3:26 PM
thakis retitled this revision from to asan/win: Disable a few tests that fail on bots with not a lot of memory..
thakis updated this object.
thakis added reviewers: rnk, etienneb.
thakis added a subscriber: llvm-commits.
thakis updated this revision to Diff 67037.Aug 5 2016, 3:26 PM

add context lines

etienneb edited edge metadata.Aug 5 2016, 3:29 PM

I'm able to repro. This bug is happening when the memory pressure on the system is too high (not enough virtual memory).

[ RUN      ] SanitizerCommon.SizeClassAllocator64GetBlockBegin
==551160==ERROR: SanitizerTool failed to allocate 0x10000 (65536) bytes of memory at address 0xd74046000 (error code: 1455)
==551160==Dumping process modules:
        0x000076fd0000-0x0000770ef000 C:\Windows\system32\kernel32.dll
        0x0000771f0000-0x00007739a000 C:\Windows\SYSTEM32\ntdll.dll
        0x00013f930000-0x00014081e000 C:\src\llvm\ninja64\projects\compiler-rt\lib\sanitizer_common\tests\Sanitizer-x86_64-Test.exe
        0x07fef51d0000-0x07fef52f5000 C:\Windows\system32\dbghelp.dll
        0x07fefa620000-0x07fefa623000 C:\Windows\system32\api-ms-win-core-synch-l1-2-0.DLL
        0x07fefd060000-0x07fefd0ca000 C:\Windows\system32\KERNELBASE.dll
        0x07fefd330000-0x07fefd40b000 C:\Windows\system32\ADVAPI32.dll
        0x07fefdc90000-0x07fefdcaf000 C:\Windows\SYSTEM32\sechost.dll
        0x07fefe110000-0x07fefe23d000 C:\Windows\system32\RPCRT4.dll
        0x07feff330000-0x07feff3cf000 C:\Windows\system32\msvcrt.dll
==551160==Sanitizer CHECK failed: C:\src\llvm\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_common.cc:120 ((0 && "unable to mmap")) != (0) (0, 0

To put pressure, I'm using sysinternal "testlimit64".

C:\src\SysInternals>testlimit64 -d -c 18000

Testlimit v5.24 - test Windows limits
Copyright (C) 2012-2015 Mark Russinovich
Sysinternals - www.sysinternals.com

Process ID: 623200

Leaking private bytes with touch (MB)...
Leaked 18000 MB of private memory (18000 MB total leaked). Lasterror: 0
The operation completed successfully.
etienneb added inline comments.Aug 5 2016, 3:31 PM
lib/sanitizer_common/tests/sanitizer_allocator_test.cc
578

That one will be flaky.

It's the same test than above, but with a "fixed" memory address.
So, issues with memory pressure should be the same.

thakis updated this revision to Diff 67042.Aug 5 2016, 3:39 PM
thakis edited edge metadata.

disable a few more

thakis marked an inline comment as done.Aug 5 2016, 3:39 PM
etienneb accepted this revision.Aug 5 2016, 3:42 PM
etienneb edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2016, 3:42 PM
thakis closed this revision.Aug 5 2016, 3:44 PM

r277882, thanks!