This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] trace buffer API to use user-allocated buffer.
ClosedPublic

Authored by aizatsky on Aug 4 2016, 5:42 PM.

Diff Detail

Event Timeline

aizatsky updated this revision to Diff 66892.Aug 4 2016, 5:42 PM
aizatsky retitled this revision from to [sanitizers] trace buffer API to uses user-allocated buffer..
aizatsky updated this object.
aizatsky retitled this revision from [sanitizers] trace buffer API to uses user-allocated buffer. to [sanitizers] trace buffer API to use user-allocated buffer..Aug 4 2016, 5:48 PM
aizatsky added reviewers: kcc, vitalybuka.
aizatsky added a project: Restricted Project.
aizatsky added a subscriber: llvm-commits.
vitalybuka edited edge metadata.Aug 4 2016, 6:06 PM

LGTM

lib/Fuzzer/FuzzerLoop.cpp
59

explicit?

141

defaults inline here?

aizatsky marked an inline comment as done.Aug 5 2016, 12:43 PM
aizatsky added inline comments.
lib/Fuzzer/FuzzerLoop.cpp
141

not sure what you mean here.

aizatsky updated this revision to Diff 66994.Aug 5 2016, 12:43 PM
aizatsky edited edge metadata.

review

aizatsky updated this revision to Diff 67000.Aug 5 2016, 1:08 PM
aizatsky marked an inline comment as done.

reviewreviewreviewreview

aizatsky marked an inline comment as not done.Aug 5 2016, 1:08 PM
aizatsky added inline comments.
lib/Fuzzer/FuzzerLoop.cpp
141

done.

vitalybuka accepted this revision.Aug 5 2016, 1:16 PM
vitalybuka edited edge metadata.
This revision is now accepted and ready to land.Aug 5 2016, 1:16 PM
This revision was automatically updated to reflect the committed changes.