Add instruction formats E, RSI, SSd, SSE, and SSF.
Added BRXH, BRXLE, PR, MVCK, STRAG, and ECTG instructions to test out
those formats.
Paths
| Differential D23179
[SystemZ] Add some missing instruction classes and instructions ClosedPublic Authored by • zhanjunl on Aug 4 2016, 2:45 PM.
Details Summary Add instruction formats E, RSI, SSd, SSE, and SSF. Added BRXH, BRXLE, PR, MVCK, STRAG, and ECTG instructions to test out
Diff Detail Event Timeline• zhanjunl retitled this revision from to [SystemZ] Add some missing instruction classes and instructions.. • zhanjunl updated this object. uweigand edited edge metadata. Comment ActionsLooks basically good to me. Some of the instructions don't have the appropriate flags set -- see inline comments. This is important even for instructions not used for codegen, since those flags can be queried via the disassembler interface (e.g. LLDB uses this to detect branches). Patch OK with those changes.
This revision is now accepted and ready to land.Aug 5 2016, 3:59 AM • zhanjunl edited edge metadata. Comment ActionsThanks for the review Ulrich, I'll try to remember to set the right flags next time. • zhanjunl retitled this revision from [SystemZ] Add some missing instruction classes and instructions. to [SystemZ] Add some missing instruction classes and instructions. • zhanjunl updated this object. Comment ActionsAdded a comment to describe BranchBinary. Closed by commit rL277822: [SystemZ] Add missing classes and instructions (authored by • zhanjunl). · Explain WhyAug 5 2016, 8:22 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 66957 lib/Target/SystemZ/SystemZInstrFormats.td
lib/Target/SystemZ/SystemZInstrInfo.td
test/MC/Disassembler/SystemZ/insns-pcrel.txt
test/MC/Disassembler/SystemZ/insns.txt
test/MC/SystemZ/insn-bad.s
test/MC/SystemZ/insn-good.s
|
These should have the isBranch and isTerminator flags set. Maybe we should have a BranchBinaryRSI helper similar to BranchUnaryRI ...