As per title.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM. See inline comments for a couple of nits.
Also, can you please add a vector regression test for more coverage and so we know that we're using the right bitwidth in that case?
lib/Transforms/InstCombine/InstCombineCompares.cpp | ||
---|---|---|
2383 | bitwidth(A) - capitalize for consistency | |
2388 | The coding standard recommends 'auto *' for pointers: |
bitwidth(A) - capitalize for consistency