Page MenuHomePhabricator

[WebAssembly] Fix CFI index for WebAssembly target to account for padding nullptr function
ClosedPublic

Authored by ddcc on Aug 3 2016, 2:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

ddcc updated this revision to Diff 66717.Aug 3 2016, 2:15 PM
ddcc retitled this revision from to [WebAssembly] Fix CFI index for WebAssembly target to account for padding nullptr function.
ddcc updated this object.
ddcc added a reviewer: dschuff.Aug 3 2016, 2:16 PM
ddcc edited subscribers, added: pcc, llvm-commits; removed: dschuff.

The WebAssembly linker now creates a dummy function at index 0 to prevent miscomparisons with the NULL pointer, see https://github.com/WebAssembly/binaryen/pull/658. Thanks to pcc for pointing out this problem!

dschuff accepted this revision.Aug 3 2016, 2:42 PM
dschuff edited edge metadata.

LGTM, thanks for fixing that.

This revision is now accepted and ready to land.Aug 3 2016, 2:42 PM
dschuff requested changes to this revision.Aug 3 2016, 4:05 PM
dschuff edited edge metadata.

Actually, I'm getting lit test failures with this patch (the changed parts of function.ll and function-ext.ll). Does that reproduce for you?

This revision now requires changes to proceed.Aug 3 2016, 4:05 PM
ddcc updated this revision to Diff 67091.Aug 6 2016, 9:51 PM
ddcc edited edge metadata.

Fix test failure

This revision was automatically updated to reflect the committed changes.

(now LGTM, FTR)