This is an archive of the discontinued LLVM Phabricator instance.

Differential D23093

[clang-tidy] Fix missing dependency to static analyzer
ClosedPublic

Authored by etienneb on Aug 2 2016, 3:44 PM.

Details

Reviewers
alexfh
Commits
rGee0627fd1b9f: [clang-tidy] Fix missing dependency to static analyzer
rCTE277539: [clang-tidy] Fix missing dependency to static analyzer
rL277539: [clang-tidy] Fix missing dependency to static analyzer
Summary

This patch is fixing the build bot broken for a missing dependency.

The missing dependency is breaking "shared" build.

./mpi/TypeMismatchCheck.cpp:
  #include "clang/StaticAnalyzer/Checkers/MPIFunctionClassifier.h"

I'm not a fan of that fix. It's brining a strange dependency.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 66577.Aug 2 2016, 3:44 PM
etienneb retitled this revision from to [clang-tidy] Fix missing dependency to static analyzer.
etienneb updated this object.
etienneb added a reviewer: alexfh.
etienneb added subscribers: • chrisha, llvm-commits.
Closed by commit rL277539: [clang-tidy] Fix missing dependency to static analyzer (authored by etienneb). · Explain WhyAug 2 2016, 3:59 PM
This revision was automatically updated to reflect the committed changes.
alexfh edited edge metadata.Aug 2 2016, 4:01 PM

Awesome, thanks!

Revision Contents

PathSize
clang-tidy/
mpi/
1 line

Diff 66577

clang-tidy/mpi/CMakeLists.txt

set(LLVM_LINK_COMPONENTS support) set(LLVM_LINK_COMPONENTS support)
add_clang_library(clangTidyMPIModule add_clang_library(clangTidyMPIModule
MPITidyModule.cpp MPITidyModule.cpp
TypeMismatchCheck.cpp TypeMismatchCheck.cpp
LINK_LIBS LINK_LIBS
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangLex clangLex
clangTidy clangTidy
clangTidyUtils clangTidyUtils
clangTooling clangTooling
clangStaticAnalyzerCheckers
) )