This is an archive of the discontinued LLVM Phabricator instance.

Differential D23084

Fix linking of omp_foreign_thread_team_reuse test on FreeBSD
ClosedPublic

Authored by dim on Aug 2 2016, 1:42 PM.

Details

Reviewers
jlpeyton
Hahnfeld
hfinkel
Commits
rG4ef81a7fdbe6: Merging r278036: --------------------------------------------------------------…
rG70ba8c506c0b: Fix linking of omp_foreign_thread_team_reuse test on FreeBSD
rOMP278036: Fix linking of omp_foreign_thread_team_reuse test on FreeBSD
rL278036: Fix linking of omp_foreign_thread_team_reuse test on FreeBSD
Summary

On FreeBSD, linking the misc_bugs/omp_foreign_thread_team_reuse.c test
case fails with:

/usr/local/bin/ld: /tmp/omp_foreign_thread_team_reuse-c5e71b.o: undefined reference to symbol 'pthread_create@@FBSD_1.0'

This is because the program is linked without -lpthread. Since the
%libomp-compile-and-run macro does not allow that option to be added to
the compile command line, split it up and add the required -lpthread
between %libomp-compile and %libomp-run.

Diff Detail

Repository
rL LLVM

Event Timeline

dim updated this revision to Diff 66546.Aug 2 2016, 1:42 PM
dim retitled this revision from to Fix linking of omp_foreign_thread_team_reuse test on FreeBSD.
dim updated this object.
dim added reviewers: jlpeyton, hfinkel.
dim added subscribers: openmp-commits, emaste.
dim added a comment.Aug 6 2016, 7:10 PM

Ping.

Hahnfeld accepted this revision.Aug 7 2016, 11:07 PM
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a subscriber: Hahnfeld.

LGTM

This revision is now accepted and ready to land.Aug 7 2016, 11:07 PM
dim closed this revision.Aug 8 2016, 11:41 AM
Closed by commit rL278036: Fix linking of omp_foreign_thread_team_reuse test on FreeBSD (authored by dim). · Explain WhyAug 8 2016, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
openmp/
trunk/
runtime/
test/
misc_bugs/
2 lines

Diff 67209

openmp/trunk/runtime/test/misc_bugs/omp_foreign_thread_team_reuse.c

// RUN: %libomp-compile-and-run // RUN: %libomp-compile -lpthread && %libomp-run
#include <stdio.h> #include <stdio.h>
#include "omp_testsuite.h" #include "omp_testsuite.h"
#define NUM_THREADS 10 #define NUM_THREADS 10
/* /*
After hot teams were enabled by default, the library started using levels After hot teams were enabled by default, the library started using levels
kept in the team structure. The levels are broken in case foreign thread kept in the team structure. The levels are broken in case foreign thread
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines