Page MenuHomePhabricator

[Include-fixer] Install executables and support scripts
ClosedPublic

Authored by Eugene.Zelenko on Aug 1 2016, 6:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [Include-fixer] Install executables and support scripts.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: ioeric, bkramer, hokein.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
hokein accepted this revision.Aug 2 2016, 12:23 AM
hokein edited edge metadata.

LGTM, thanks!

include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

I think we can put it in clang-include-fixer as find-all-symbols is a sub-tool of include-fixer.

This revision is now accepted and ready to land.Aug 2 2016, 12:23 AM
Eugene.Zelenko added inline comments.Aug 2 2016, 10:11 AM
include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

In other make files executable name and COMPONENT for scripts are same. Should I add COMPONENT to find-all-symbols executable too?

Ping. I could not proceed until my question answered.

Sorry for the delay. I totally missed it.

include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

My previous comment is just my personal preference, not a strong opinion. The patch is good enough now, feel free to submit it.

Keeping the find-all-symbols executable binary in RUNTIME DESTINATION bin is fine.

This revision was automatically updated to reflect the committed changes.