This is an archive of the discontinued LLVM Phabricator instance.

Differential D23045

[Include-fixer] Install executables and support scripts
ClosedPublic

Authored by Eugene.Zelenko on Aug 1 2016, 6:45 PM.

Details

Reviewers
ioeric
hokein
bkramer
Commits
rGc400b144b3d1: Merging r278949: (excluding the clang-include-fixer.el part)…
rG473da657c720: [Include-fixer] Install executables and support scripts
rCTE278949: [Include-fixer] Install executables and support scripts
rL278949: [Include-fixer] Install executables and support scripts
Summary

I tested this changes on my RHEL 6 build.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko updated this revision to Diff 66414.Aug 1 2016, 6:45 PM
Eugene.Zelenko retitled this revision from to [Include-fixer] Install executables and support scripts.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: ioeric, bkramer, hokein.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
hokein accepted this revision.Aug 2 2016, 12:23 AM
hokein edited edge metadata.

LGTM, thanks!

include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

I think we can put it in clang-include-fixer as find-all-symbols is a sub-tool of include-fixer.

This revision is now accepted and ready to land.Aug 2 2016, 12:23 AM
Eugene.Zelenko added inline comments.Aug 2 2016, 10:11 AM
include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

In other make files executable name and COMPONENT for scripts are same. Should I add COMPONENT to find-all-symbols executable too?

Eugene.Zelenko added a comment.Aug 12 2016, 10:53 AM

Ping. I could not proceed until my question answered.

hokein added a comment.Aug 17 2016, 1:26 AM

Sorry for the delay. I totally missed it.

include-fixer/find-all-symbols/tool/CMakeLists.txt
22 ↗(On Diff #66414)

My previous comment is just my personal preference, not a strong opinion. The patch is good enough now, feel free to submit it.

Keeping the find-all-symbols executable binary in RUNTIME DESTINATION bin is fine.

Closed by commit rL278949: [Include-fixer] Install executables and support scripts (authored by eugenezelenko). · Explain WhyAug 17 2016, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
trunk/
include-fixer/
find-all-symbols/
tool/
13 lines
tool/
15 lines

Diff 68384

clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
add_clang_executable(find-all-symbols FindAllSymbolsMain.cpp) add_clang_executable(find-all-symbols
target_link_libraries(find-all-symbols FindAllSymbolsMain.cpp
)
target_link_libraries(find-all-symbols
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangTooling clangTooling
findAllSymbols findAllSymbols
) )
install(TARGETS find-all-symbols
RUNTIME DESTINATION bin)
install(PROGRAMS run-find-all-symbols.py
DESTINATION share/clang
COMPONENT find-all-symbols)

clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt

include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
add_clang_executable(clang-include-fixer ClangIncludeFixer.cpp) add_clang_executable(clang-include-fixer
ClangIncludeFixer.cpp
)
target_link_libraries(clang-include-fixer target_link_libraries(clang-include-fixer
clangBasic clangBasic
clangFormat clangFormat
clangFrontend clangFrontend
clangIncludeFixer clangIncludeFixer
clangRewrite clangRewrite
clangTooling clangTooling
clangToolingCore clangToolingCore
findAllSymbols findAllSymbols
) )
install(TARGETS clang-include-fixer
RUNTIME DESTINATION bin)
install(PROGRAMS clang-include-fixer.el
DESTINATION share/clang
COMPONENT clang-include-fixer)
install(PROGRAMS clang-include-fixer.py
DESTINATION share/clang
COMPONENT clang-include-fixer)