rnk reported that MSVC ignores unknown flags and still returns 0. This should cause unknown flags to be an error during the compiler check.
Details
Details
Diff Detail
Diff Detail
Event Timeline
cmake/Modules/BuiltinTests.cmake | ||
---|---|---|
1 | That was also my first thought, but the file has this comment: # Do NOT include this module directly into any of your code. It is meant as # a library for Check*CompilerFlag.cmake modules. It's content may change in # any way between releases. Think we should do it anyway? | |
44 | I think you meant if ("${var}" STREQUAL "FAIL_REGEX") |
cmake/Modules/BuiltinTests.cmake | ||
---|---|---|
1 | My gut is to include it anyway. The alternative is to mimic what it does. @brad.king might have thoughts. Despite saying that, the macro's structure hasn't really changed ever. | |
44 | Duh... |
Comment Actions
Thanks for dealing with that!
cmake/Modules/BuiltinTests.cmake | ||
---|---|---|
2 | We can duplicate the relevant parts when and if it breaks. |
That was also my first thought, but the file has this comment:
Think we should do it anyway?