Page MenuHomePhabricator

brad.king (Brad King)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2014, 1:46 PM (403 w, 2 d)

Recent Activity

Mar 12 2019

brad.king resigned from D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Mar 12 2019, 5:36 AM · Restricted Project, Restricted Project

May 8 2018

brad.king added a comment to D46521: [llvm] cmake: resolve symlinks in LLVMConfig.cmake.

For reference, CMake's own install(EXPORT) does a similar REALPATH trick here. The goal is to overcome cross-prefix symlinks. CMake doesn't actually use the realpath directly, but the realpath of the original installation prefix and the realpath of the location from which the file is loaded are the same, then it uses the original installation prefix instead of the path used to load the file. This achieves robustness against cross-prefix symlinks while still allowing the package to be relocatable.

May 8 2018, 6:59 AM

Sep 6 2017

brad.king abandoned D37381: Fix regression in special member definitions under SuppressAllDiagnostics.

@rsmith thanks.

Sep 6 2017, 4:26 AM

Sep 1 2017

brad.king updated the diff for D37381: Fix regression in special member definitions under SuppressAllDiagnostics.

Updated diff to add a test case.

Sep 1 2017, 11:32 AM
brad.king added a comment to D37381: Fix regression in special member definitions under SuppressAllDiagnostics.

make check didn't regress from this.

Sep 1 2017, 8:58 AM
brad.king updated the diff for D37381: Fix regression in special member definitions under SuppressAllDiagnostics.

Updated diff with full context.

Sep 1 2017, 8:53 AM
brad.king added a comment to rL303930: Switch from using a DiagnosticTrap and a note for "while defining a special.

Removing the DiagnosticErrorTrap here breaks semantic checking of special members when SuppressAllDiagnostics is in effect. See https://reviews.llvm.org/D37381 for a fix.

Sep 1 2017, 8:36 AM
brad.king created D37381: Fix regression in special member definitions under SuppressAllDiagnostics.
Sep 1 2017, 8:34 AM

Mar 1 2017

brad.king added a comment to D30467: Use relative path to clang-cl.

The CMAKE_C_COMPILER: ../build/bin/clang-cl.exe is not a full path and was not found in the PATH

Mar 1 2017, 9:01 AM

Feb 28 2017

brad.king added a comment to D30467: Use relative path to clang-cl.

If the CMAKE_C_COMPILER value is not provided to CMake then its logic for initializing it is part of the enable-language logic done inside the project or enable_language command. Therefore in general project code should not try to touch it.

Feb 28 2017, 11:46 AM

Oct 3 2016

brad.king added a comment to D25155: [Polly] Build and run isl_test as part of check-polly.

make a add_custom_command be silent in non-verbose mode

Oct 3 2016, 5:05 AM

Sep 23 2016

brad.king added a comment to D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127. .

ensuring that when static .a libraries are build they only introduce cmake transitive dependencies to other .a components.

Sep 23 2016, 7:08 AM · Restricted Project

Aug 15 2016

brad.king added a comment to D23455: [Tooling] Parse compilation database command lines properly on Windows.

the feasibility of emitting 'arguments' instead of 'command' into the JSON compilation database.

Aug 15 2016, 11:00 AM

May 3 2016

brad.king added a comment to D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226).

I do not think MSVC starts off with an empty line with -showIncludes specifically. It is just that MSVC unconditionally prints the name of the source file first. This means that any showIncludes output is naturally preceded by a newline because at least one other line was printed first. If clang-cl is to have compatible output with MS cl then it should print the source file name first too. However, that would be a broader decision that should stand on its own.

May 3 2016, 11:34 AM

Nov 9 2015

brad.king added a comment to D13198: Fix `llvm-config` to adapt to the install environment..

I applied the updated changes on top of r252467 and built all combinations of:

Nov 9 2015, 12:06 PM

Nov 6 2015

brad.king added a comment to D13198: Fix `llvm-config` to adapt to the install environment..

After a minor fix this now compiles and gives the proper --libfiles paths on OS X with both CMake and autoconf builds.

Nov 6 2015, 5:59 AM

Nov 4 2015

brad.king added a comment to D13198: Fix `llvm-config` to adapt to the install environment..

Thanks for running a build! Does Darwin's autoconf do the same? (EDIT: grammars)

Nov 4 2015, 7:34 AM

Nov 2 2015

brad.king added a comment to D13198: Fix `llvm-config` to adapt to the install environment..

Sorry for the delay. Overall the changes look good. The configuration of BuildVariables.inc looks right.

Nov 2 2015, 10:20 AM

Aug 7 2015

brad.king added inline comments to D11835: Make `llvm-config` work when static versions of LLVM's components aren't installed..
Aug 7 2015, 12:42 PM