This is an archive of the discontinued LLVM Phabricator instance.

Differential D22984

[lldb][tsan] Avoid some string copies (NFC)
ClosedPublic

Authored by vsk on Jul 29 2016, 5:13 PM.

Details

Reviewers
compnerd
kubamracek
Commits
rG728b9abb3f6e: [lldb][tsan] Avoid a string copy (NFC)
rLLDB277347: [lldb][tsan] Avoid a string copy (NFC)
rL277347: [lldb][tsan] Avoid a string copy (NFC)

Diff Detail

Event Timeline

vsk updated this revision to Diff 66202.Jul 29 2016, 5:13 PM
vsk retitled this revision from to [lldb][tsan] Avoid a string copy (NFC).
vsk updated this object.
vsk added a reviewer: kubamracek.
vsk added a subscriber: llvm-commits.
compnerd added a subscriber: compnerd.Jul 29 2016, 6:32 PM
compnerd added inline comments.
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
289

Why not make count_name a const std::string & as well?

vsk updated this revision to Diff 66208.Jul 29 2016, 6:38 PM
vsk retitled this revision from [lldb][tsan] Avoid a string copy (NFC) to [lldb][tsan] Avoid some string copies (NFC).
  • Catch a few more copies pointed out by @compnerd.
compnerd accepted this revision.Jul 29 2016, 9:18 PM
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.Jul 29 2016, 9:18 PM
Closed by commit rL277347: [lldb][tsan] Avoid a string copy (NFC) (authored by vedantk). · Explain WhyAug 1 2016, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
source/
Plugins/
InstrumentationRuntime/
ThreadSanitizer/
2 lines

Diff 66202

source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
if (trace_addr == 0) if (trace_addr == 0)
break; break;
trace->AddItem(StructuredData::ObjectSP(new StructuredData::Integer(trace_addr))); trace->AddItem(StructuredData::ObjectSP(new StructuredData::Integer(trace_addr)));
} }
return StructuredData::ObjectSP(trace); return StructuredData::ObjectSP(trace);
} }
static StructuredData::Array * static StructuredData::Array *
ConvertToStructuredArray(ValueObjectSP return_value_sp, std::string items_name, std::string count_name, std::function <void(ValueObjectSP o, StructuredData::Dictionary *dict)> const &callback) ConvertToStructuredArray(ValueObjectSP return_value_sp, const std::string &items_name, std::string count_name, std::function <void(ValueObjectSP o, StructuredData::Dictionary *dict)> const &callback)
compnerdUnsubmitted
Not Done
ReplyInline Actions

Why not make count_name a const std::string & as well?

compnerd: Why not make count_name a `const std::string &` as well?
{ {
StructuredData::Array *array = new StructuredData::Array(); StructuredData::Array *array = new StructuredData::Array();
unsigned int count = return_value_sp->GetValueForExpressionPath(count_name.c_str())->GetValueAsUnsigned(0); unsigned int count = return_value_sp->GetValueForExpressionPath(count_name.c_str())->GetValueAsUnsigned(0);
ValueObjectSP objects = return_value_sp->GetValueForExpressionPath(items_name.c_str()); ValueObjectSP objects = return_value_sp->GetValueForExpressionPath(items_name.c_str());
for (unsigned int i = 0; i < count; i++) { for (unsigned int i = 0; i < count; i++) {
ValueObjectSP o = objects->GetChildAtIndex(i, true); ValueObjectSP o = objects->GetChildAtIndex(i, true);
StructuredData::Dictionary *dict = new StructuredData::Dictionary(); StructuredData::Dictionary *dict = new StructuredData::Dictionary();
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines