Page MenuHomePhabricator

[lldb][tsan] Avoid some string copies (NFC)
ClosedPublic

Authored by vsk on Jul 29 2016, 5:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk updated this revision to Diff 66202.Jul 29 2016, 5:13 PM
vsk retitled this revision from to [lldb][tsan] Avoid a string copy (NFC).
vsk updated this object.
vsk added a reviewer: kubamracek.
vsk added a subscriber: llvm-commits.
compnerd added inline comments.
source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
289 ↗(On Diff #66202)

Why not make count_name a const std::string & as well?

vsk updated this revision to Diff 66208.Jul 29 2016, 6:38 PM
vsk retitled this revision from [lldb][tsan] Avoid a string copy (NFC) to [lldb][tsan] Avoid some string copies (NFC).
  • Catch a few more copies pointed out by @compnerd.
compnerd accepted this revision.Jul 29 2016, 9:18 PM
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.Jul 29 2016, 9:18 PM
This revision was automatically updated to reflect the committed changes.