Page MenuHomePhabricator

Add Percent Symbol Before Named PPC Registers
Needs ReviewPublic

Authored by tjablin on Jul 28 2016, 4:51 PM.

Details

Reviewers
kbarton
hfinkel
Summary

The -ppc-asm-full-reg-names flag causes LLVM to generate named PPC registers instead of numbers. However, the resulting assembly code was not parsable by either GCC or LLVM due to missing percent symbols before register names. This patch inserts a percent sign before register names on PPC when -ppc-asm-full-reg-names is enabled except for the registers PPC::ZERO and other special registers that do not require the percent symbol.

Diff Detail

Event Timeline

tjablin updated this revision to Diff 66058.Jul 28 2016, 4:51 PM
tjablin retitled this revision from to Add Percent Symbol Before Named PPC Registers.
tjablin updated this object.
tjablin added reviewers: kbarton, hfinkel.
tjablin added a subscriber: llvm-commits.
gut added a subscriber: gut.Oct 10 2017, 4:48 AM

Hi. This change seems interesting, why wasn't it reviewed?

Our team is considering implementing such a thing for POWER8 but then we noticed this patch.

In D22948#892973, @gut wrote:

Hi. This change seems interesting, why wasn't it reviewed?

Our team is considering implementing such a thing for POWER8 but then we noticed this patch.

The author never pinged it and it dropped off of people's radar. Is this of interest to you? The option that this helps with is seldom used - and only in testing, so this wasn't anyone's top priority. If you'd like to see this through, commandeer the patch, update it so it applies to (and passes all tests on) trunk and re-post.
I don't expect any of the reviewers will have an issue approving it.

gut added a comment.Oct 10 2017, 6:00 AM

Alright, thanks for letting us know that there was no implicit rejection to this kind of functionality. We'll take a closer look and commandeer this review when the other review is available.