When we ask the builder to create a bitcast on a constant, we get back a
constant, not an instruction.
Details
Details
Diff Detail
Diff Detail
Event Timeline
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp | ||
---|---|---|
972 | Looking back at this, why do we need a small vector for instructions to reorder and not just one instruction (which now may or may not exist)? | |
975 | Can you rename I to something else? It's being used right below as an unsigned iterator, and while the two scopes don't overlap, it can be confusing. | |
1003 | Same as above. |
Comment Actions
There are other places where we're assuming that Builder gives us an instruction when it doesn't, but I'd like to deal with those in a separate patch.
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp | ||
---|---|---|
972 | lol, good point. Fixed. |
Looking back at this, why do we need a small vector for instructions to reorder and not just one instruction (which now may or may not exist)?