This is an archive of the discontinued LLVM Phabricator instance.

Differential D22860

[ARM] Check that the thumb COFF segment flag gets set with a thumb windows triplet
ClosedPublic

Authored by mstorsjo on Jul 27 2016, 6:35 AM.

Details

Reviewers
rengolin

Diff Detail

Event Timeline

mstorsjo updated this revision to Diff 65726.Jul 27 2016, 6:35 AM
mstorsjo retitled this revision from to [ARM] Check that the thumb COFF segment flag gets set with a thumb windows triplet.
mstorsjo updated this object.
mstorsjo added a subscriber: llvm-commits.
Herald added subscribers: samparker, rengolin, aemerson. · View Herald TranscriptJul 27 2016, 6:35 AM
rengolin added inline comments.Jul 27 2016, 6:45 AM
test/MC/ARM/Windows/thumb-attributes.s
15

You don't need those, just the two DAGs after the Section. Something like:

@ CHECK: Section
@ CHECK-DAG: IMAGE_SCN_CNT_CODE
​@ CHECK-DAG: IMAGE_SCN_MEM_16BIT

Also, avoid using TABs.

mstorsjo updated this revision to Diff 65732.Jul 27 2016, 6:58 AM

Updated the test according to the suggestions

rengolin accepted this revision.Jul 27 2016, 6:58 AM
rengolin added a reviewer: rengolin.

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 27 2016, 6:58 AM
rengolin closed this revision.Jul 27 2016, 7:45 AM

Committed in r276877.

Revision Contents

PathSize
test/
MC/
ARM/
Windows/
16 lines

Diff 65732

test/MC/ARM/Windows/thumb-attributes.s

  • This file was added.
@ RUN: llvm-mc -triple thumbv7-windows-itanium -filetype obj -o - %s \
@ RUN: | llvm-readobj -s - | FileCheck %s
.syntax unified
.thumb
.text
.global function
.thumb_func
function:
bx lr
@ CHECK: Section
@ CHECK-DAG: IMAGE_SCN_CNT_CODE
rengolinUnsubmitted
Not Done
ReplyInline Actions

You don't need those, just the two DAGs after the Section. Something like:

@ CHECK: Section
@ CHECK-DAG: IMAGE_SCN_CNT_CODE
​@ CHECK-DAG: IMAGE_SCN_MEM_16BIT

Also, avoid using TABs.

rengolin: You don't need those, just the two DAGs after the Section. Something like: @ CHECK…
@ CHECK-DAG: IMAGE_SCN_MEM_16BIT