This is an archive of the discontinued LLVM Phabricator instance.

Differential D22843

cmake: Option to enable/disable bitcode + clang version check
ClosedPublic

Authored by MatzeB on Jul 26 2016, 7:01 PM.

Details

Reviewers
asbirlea
Summary

Add an option to enable/disable bitcode tests. The option is enabled automatically if "mainline" clang (as opposed to apple clang) is detected with a new enough version.

Diff Detail

Repository
rL LLVM

Event Timeline

MatzeB updated this revision to Diff 65646.Jul 26 2016, 7:01 PM
MatzeB retitled this revision from to cmake: Option to enable/disable bitcode + clang version check.
MatzeB updated this object.
MatzeB added a reviewer: asbirlea.
MatzeB set the repository for this revision to rL LLVM.
MatzeB added subscribers: mehdi_amini, llvm-commits.
Herald added a subscriber: mcrosier. · View Herald TranscriptJul 26 2016, 7:01 PM
asbirlea accepted this revision.Jul 26 2016, 10:52 PM
asbirlea edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 26 2016, 10:52 PM
asbirlea mentioned this in D22836: Add option to diable Bitcode tests. Tests are enabled by default..Jul 26 2016, 11:00 PM
asbirlea added a comment.Jul 27 2016, 10:05 PM

I see that the aarch64 tests broke this: http://lab.llvm.org:8080/green//job/Compiler_Verifiers/3159/consoleFull#139518741949ba4694-19c4-4d7e-bec5-911270d8a58c

It's using clang 3.8 though. Pinging this patch to at least have the >3.9 check added.
(Though I tested with 3.8 and it still breaks, but differently. I can't reproduce the failure at 3.9.)

MatzeB added a comment.Jul 28 2016, 10:26 AM

I'll push this patch. I am pretty sure though that that bot uses a ToT compiler and not a 3.8...

asbirlea added a comment.Jul 28 2016, 10:30 AM

Thanks!
The error message is prepended with "clang-3.8:" so I assumed that's the version it's using.
Suggestions on who to contact to try and figure this out?

MatzeB added a comment.Jul 28 2016, 10:33 AM
In D22843#499497, @asbirlea wrote:

Thanks!
The error message is prepended with "clang-3.8:" so I assumed that's the version it's using.
Suggestions on who to contact to try and figure this out?

Hmm we really should be testing ToT with the compiler verifier builder but it does say 3.8 indeed...
Chris Matthews <chris.matthews@apple.com> is the best person to contact about green dragon.

MatzeB closed this revision.Jul 28 2016, 10:36 AM

Comitted in r277010

asbirlea added a comment.Jul 28 2016, 2:30 PM

@MatzeB: just FYI, this did fix green dragon. Thanks!

Revision Contents

PathSize
Bitcode/
20 lines

Diff 65646

Bitcode/CMakeLists.txt

# We need at least clang 3.9 to process the bitcode here.
if(CMAKE_C_COMPILER_ID STREQUAL "Clang" AND
CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
NOT CMAKE_C_COMPILER_VERSION VERSION_LESS "3.9" AND
NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS "3.9")
set(ENABLE_BITCODE_DEFAULT "True")
endif()
set(TEST_SUITE_ENABLE_BITCODE_TESTS ${ENABLE_BITCODE_DEFAULT} CACHE BOOL "Enable bitcode tests")
if(TEST_SUITE_ENABLE_BITCODE_TESTS)
if(NOT TEST_SUITE_BENCHMARKING_ONLY) if(NOT TEST_SUITE_BENCHMARKING_ONLY)
llvm_add_subdirectories(Regression) llvm_add_subdirectories(Regression)
if(ARCH STREQUAL "x86") if(ARCH STREQUAL "x86")
llvm_add_subdirectories(simd_ops) llvm_add_subdirectories(simd_ops)
endif() endif()
endif() endif()
endif()