This is an archive of the discontinued LLVM Phabricator instance.

[test/gold] Add gold test subdirectory tests needing v1.12 (or higher)
ClosedPublic

Authored by tejohnson on Jul 26 2016, 11:39 AM.

Details

Summary

As discussed in the review for D22677, added a subdirectory to
enable tests that require at least version 1.12 of gold.

Add an initial test requiring this version.

Another option would be to add this as a new available_feature in
test/lit.cfg and place the new tests directly in test/tools/gold/X86
with a REQUIRES tag.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson updated this revision to Diff 65568.Jul 26 2016, 11:39 AM
tejohnson retitled this revision from to [test/gold] Add gold test subdirectory tests needing v1.12 (or higher).
tejohnson updated this object.
tejohnson added reviewers: davidxl, mehdi_amini.
tejohnson added a subscriber: llvm-commits.
davidxl added inline comments.Jul 26 2016, 1:32 PM
test/tools/gold/X86/v1.12/lit.local.cfg
18 ↗(On Diff #65568)

probably just look at the minor version and use integer comparison? version 1.2 should be older version right?

hjl.tools added inline comments.
test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll
13 ↗(On Diff #65568)

"-m elf_x86_64" is needed for

target triple = "x86_64-unknown-linux-gnu" ​

tejohnson added inline comments.Jul 26 2016, 1:37 PM
test/tools/gold/X86/v1.12/lit.local.cfg
18 ↗(On Diff #65568)

Ah yes, good catch. I should probably compare both separately, in case the major version ever increases. Will fix.

tejohnson added inline comments.Jul 26 2016, 1:47 PM
test/tools/gold/X86/v1.12/lit.local.cfg
18 ↗(On Diff #65568)

Fixed.

test/tools/gold/X86/v1.12/thinlto_emit_linked_objects.ll
13 ↗(On Diff #65568)

Fixed

tejohnson updated this revision to Diff 65596.Jul 26 2016, 1:47 PM
  • Address comments
davidxl accepted this revision.Jul 26 2016, 1:53 PM
davidxl edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 26 2016, 1:53 PM
This revision was automatically updated to reflect the committed changes.
MatzeB added a subscriber: MatzeB.Jul 28 2016, 11:51 AM

This leads to the output of "ld -v" getting shown on my terminal every time I run "ninja check-llvm" on my macOS system.
(For some reason lit.site.cfg also has config.gold_executable pointing to /usr/bin/ld even though I am pretty sure that is not a gold linker on my machine).