Page MenuHomePhabricator

Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets
ClosedPublic

Authored by omjavaid on Jul 25 2016, 12:12 PM.

Details

Summary

This patch allows correct selection of CMAKE_LIBRARY_ARCHITECTURE instead of previously hard-coded value.

All cross builds for 64bit targets with python support enabled will fail in absence of this patch

I am trying to get LLDB host build working on AArch64 native host running ubuntu Xenial 64bit.

My build system is ubuntu 16.04 amd64.

I am able to build LLDB successfully on Ubuntu Trusty 14.04 and 16.04 after applying this patch.

Please review if there are any possible build breakups due to this patch.

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 65397.Jul 25 2016, 12:12 PM
omjavaid retitled this revision from to Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets.
omjavaid updated this object.
omjavaid added reviewers: labath, Eugene.Zelenko.
omjavaid added a subscriber: lldb-commits.
Eugene.Zelenko edited reviewers, added: zturner; removed: Eugene.Zelenko.Jul 25 2016, 2:20 PM
Eugene.Zelenko set the repository for this revision to rL LLVM.
labath edited edge metadata.Jul 26 2016, 1:03 AM

It seems this was added in 2014 for cross-compilation for android. Given that it's in a if ! PYTHON block and we don't use python anymore on android, I think it's pretty safe to remove.

Thanks.

I am going ahead and committing this patch. If it breaks any build please revert it.

This revision was automatically updated to reflect the committed changes.