Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets

[omjavaid]

Summary

This patch allows correct selection of CMAKE_LIBRARY_ARCHITECTURE instead of previously hard-coded value.

All cross builds for 64bit targets with python support enabled will fail in absence of this patch

I am trying to get LLDB host build working on AArch64 native host running ubuntu Xenial 64bit.

My build system is ubuntu 16.04 amd64.

I am able to build LLDB successfully on Ubuntu Trusty 14.04 and 16.04 after applying this patch.

Please review if there are any possible build breakups due to this patch.

[labath]

It seems this was added in 2014 for cross-compilation for android. Given that it's in a if ! PYTHON block and we don't use python anymore on android, I think it's pretty safe to remove.

Thanks.

[omjavaid]

I am going ahead and committing this patch. If it breaks any build please revert it.

lldb/trunk/cmake/modules/LLDBConfig.cmake

function(find_python_libs_windows)
 
   message("-- LLDB Found PythonExecutable: ${PYTHON_RELEASE_EXE} and ${PYTHON_DEBUG_EXE}")
   message("-- LLDB Found PythonLibs: ${PYTHON_RELEASE_LIB} and ${PYTHON_DEBUG_LIB}")
   message("-- LLDB Found PythonDLL: ${PYTHON_RELEASE_DLL} and ${PYTHON_DEBUG_DLL}")
   message("-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIRS}")
 endfunction(find_python_libs_windows)
 
 if (NOT LLDB_DISABLE_PYTHON)
-  if(UNIX)
-    # This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a proper fix.
-    if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-      set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
-    endif()
-  endif()
 
   if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
     find_python_libs_windows()
 
     if (NOT LLDB_RELOCATABLE_PYTHON)
       file(TO_CMAKE_PATH "${PYTHON_HOME}" LLDB_PYTHON_HOME)
       add_definitions( -DLLDB_PYTHON_HOME="${LLDB_PYTHON_HOME}" )
     endif()