[llvm-cov] - Improve llvm-cov error message

[MaggieYi]

Summary

When giving the following command:
% llvm-cov report -instr-profile=default.profraw

llvm-cov will give the following error message:

llvm-cov report: Not enough positional command line arguments specified!
Must specify at least 1 positional arguments: See: orbis-llvm-cov report –help

This patch changes the error message from “1 positional arguments” to “1 positional argument”.

[vsk]

Thanks, LGTM.

lib/Support/CommandLine.cpp

bool CommandLineParser::ParseCommandLineOptions(int argc,
   }
 
   // Check and handle positional arguments now...
   if (NumPositionalRequired > PositionalVals.size()) {
     if (!IgnoreErrors) {
       errs() << ProgramName
              << ": Not enough positional command line arguments specified!\n"
              << "Must specify at least " << NumPositionalRequired
-             << " positional arguments: See: " << argv[0] << " -help\n";
+             << " positional argument" << (NumPositionalRequired > 1 ? "s" : "")
+             << ": See: " << argv[0] << " - help\n";
     }
 
     ErrorParsing = true;
   } else if (!HasUnlimitedPositionals &&
              PositionalVals.size() > PositionalOpts.size()) {
     if (!IgnoreErrors) {
       errs() << ProgramName << ": Too many positional arguments specified!\n"
              << "Can specify at most " << PositionalOpts.size()

test/tools/llvm-cov/universal-binary.c

 // The coverage reader should be able to handle universal binaries
 
 // CHECK: 100| [[@LINE+1]]|int main
 int main(int argc, const char *argv[]) {}
 
 // RUN: llvm-profdata merge %S/Inputs/universal-binary.proftext -o %t.profdata
 // RUN: llvm-cov show %S/Inputs/universal-binary -instr-profile %t.profdata -filename-equivalence %s -arch x86_64 | FileCheck %s
 
 // RUN: not llvm-cov show %S/Inputs/universal-binary -instr-profile %t.profdata -filename-equivalence %s -arch i386 2>&1 | FileCheck --check-prefix=WRONG-ARCH %s
 // WRONG-ARCH: Failed to load coverage
+
+// RUN: not llvm-cov report -instr-profile %t.profdata 2>&1 | FileCheck --check-prefix=MISSING-BINARY %s
+// MISSING-BINARY: 1 positional argument: See: