This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Enable the load-store vectorizer on nvptx.
ClosedPublic

Authored by jlebar on Jul 20 2016, 2:04 PM.

Diff Detail

Event Timeline

jlebar updated this revision to Diff 64757.Jul 20 2016, 2:04 PM
jlebar retitled this revision from to [NVPTX] Enable the load-store vectorizer on nvptx..
jlebar updated this object.
jlebar added a reviewer: tra.
jlebar added subscribers: asbirlea, arsenm, jholewinski.
tra edited edge metadata.Jul 20 2016, 2:49 PM

Are there any tests that demonstrate that we do manage to vectorize something?

lib/Target/NVPTX/NVPTXTargetMachine.cpp
61

-no- in the middle of the option looks a bit strange. It's not clear whether it's to disable something or enable something which happens to have 'no' in the name (a-la -enable-no-nans-fp-math).

Using -no or -disable prefix would be better, IMO.

jlebar updated this revision to Diff 64776.Jul 20 2016, 3:06 PM
jlebar marked an inline comment as done.
jlebar edited edge metadata.

Address review comments.

Are there any tests that demonstrate that we do manage to vectorize something?

Bah, who needs tests?

Added. :)

lib/Target/NVPTX/NVPTXTargetMachine.cpp
61

I thought it would be good to namespace the flag this way, but it looks like nobody does this. So, changed, thanks.

tra accepted this revision.Jul 20 2016, 3:17 PM
tra edited edge metadata.

LGTM, other than description for the option.

lib/Target/NVPTX/NVPTXTargetMachine.cpp
62

'Enable' does not sound right here. :-)

This revision is now accepted and ready to land.Jul 20 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.Jul 20 2016, 3:19 PM
jlebar added inline comments.
lib/Target/NVPTX/NVPTXTargetMachine.cpp
62

Ha, thanks. :)