Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant address space.
Images will still be generated in global address space by default.
Added tests to existing opencl-types.cl in test\CodeGenOpenCL
Paths
| Differential D22523
[OpenCL] AMDGCN target will generate images in constant address space ClosedPublic Authored by ashi1 on Jul 19 2016, 11:11 AM.
Details Summary Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant address space. Added tests to existing opencl-types.cl in test\CodeGenOpenCL
Diff Detail
Event Timeline
ashi1 marked an inline comment as done. Comment ActionsRevised based on Sam's comments. Also updated test file to changes with using triple spir-unknown-unknown. This revision is now accepted and ready to land.Jul 19 2016, 12:20 PM Anastasia edited edge metadata. Comment ActionsLGTM!
ashi1 edited edge metadata. ashi1 marked an inline comment as done. Comment ActionsRemoved excess semicolon by Anastasia's comments Closed by commit rL276161: [OpenCL] AMDGCN target will generate images in constant address space (authored by yaxunl). · Explain WhyJul 20 2016, 12:28 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 64538 lib/CodeGen/CGOpenCLRuntime.cpp
lib/CodeGen/TargetInfo.h
lib/CodeGen/TargetInfo.cpptest/CodeGenOpenCL/opencl_types.cl |
can you remove one ;