This is an archive of the discontinued LLVM Phabricator instance.

Differential D22453

[Compiler-rt][MIPS] Fix simple test failure when using gcc
ClosedPublic

Authored by mohit.bhakkad on Jul 17 2016, 11:11 PM.

Details

Reviewers
dsanders
vkalintiris
Commits
rGd7ae23b56363: [Compiler-rt][MIPS] Fix simple test failure when using gcc
rCRT275780: [Compiler-rt][MIPS] Fix simple test failure when using gcc
rL275780: [Compiler-rt][MIPS] Fix simple test failure when using gcc
Summary

n64 is invalid argument to -mabi for gcc compiler:

gcc: error: unrecognized argument in option ‘-mabi=n64’
gcc: note: valid arguments to ‘-mabi=’ are: 32 64 eabi n32 o64

and in clang both -mabi=n64 and -mabi=64 points to n64 abi.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad updated this revision to Diff 64274.Jul 17 2016, 11:11 PM
mohit.bhakkad retitled this revision from to [Compiler-rt][MIPS] Fix simple test failure when using gcc.
mohit.bhakkad updated this object.
mohit.bhakkad added a reviewer: dsanders.
mohit.bhakkad set the repository for this revision to rL LLVM.
mohit.bhakkad added subscribers: llvm-commits, Restricted Project, jaydeep, slthakur.
Herald added a reviewer: vkalintiris. · View Herald TranscriptJul 17 2016, 11:11 PM
dsanders accepted this revision.Jul 18 2016, 2:02 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 18 2016, 2:02 AM
Closed by commit rL275780: [Compiler-rt][MIPS] Fix simple test failure when using gcc (authored by mohit.bhakkad). · Explain WhyJul 18 2016, 2:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
cmake/
4 lines

Diff 64287

compiler-rt/trunk/cmake/base-config-ix.cmake

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Lines elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "s390x")
test_target_arch(s390x "" "") test_target_arch(s390x "" "")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mipsel|mips64el") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mipsel|mips64el")
# Gcc doesn't accept -m32/-m64 so we do the next best thing and use # Gcc doesn't accept -m32/-m64 so we do the next best thing and use
# -mips32r2/-mips64r2. We don't use -mips1/-mips3 because we want to match # -mips32r2/-mips64r2. We don't use -mips1/-mips3 because we want to match
# clang's default CPU's. In the 64-bit case, we must also specify the ABI # clang's default CPU's. In the 64-bit case, we must also specify the ABI
# since the default ABI differs between gcc and clang. # since the default ABI differs between gcc and clang.
# FIXME: Ideally, we would build the N32 library too. # FIXME: Ideally, we would build the N32 library too.
test_target_arch(mipsel "" "-mips32r2" "--target=mipsel-linux-gnu") test_target_arch(mipsel "" "-mips32r2" "--target=mipsel-linux-gnu")
test_target_arch(mips64el "" "-mips64r2" "--target=mips64el-linux-gnu" "-mabi=n64") test_target_arch(mips64el "" "-mips64r2" "--target=mips64el-linux-gnu" "-mabi=64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mips") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "mips")
test_target_arch(mips "" "-mips32r2" "--target=mips-linux-gnu") test_target_arch(mips "" "-mips32r2" "--target=mips-linux-gnu")
test_target_arch(mips64 "" "-mips64r2" "--target=mips64-linux-gnu" "-mabi=n64") test_target_arch(mips64 "" "-mips64r2" "--target=mips64-linux-gnu" "-mabi=64")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "arm") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "arm")
test_target_arch(arm "" "-march=armv7-a" "-mfloat-abi=soft") test_target_arch(arm "" "-march=armv7-a" "-mfloat-abi=soft")
test_target_arch(armhf "" "-march=armv7-a" "-mfloat-abi=hard") test_target_arch(armhf "" "-march=armv7-a" "-mfloat-abi=hard")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "aarch32") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "aarch32")
test_target_arch(aarch32 "" "-march=armv8-a") test_target_arch(aarch32 "" "-march=armv8-a")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "aarch64") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "aarch64")
test_target_arch(aarch64 "" "-march=armv8-a") test_target_arch(aarch64 "" "-march=armv8-a")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "wasm32") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "wasm32")
test_target_arch(wasm32 "" "--target=wasm32-unknown-unknown") test_target_arch(wasm32 "" "--target=wasm32-unknown-unknown")
elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "wasm64") elseif("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "wasm64")
test_target_arch(wasm64 "" "--target=wasm64-unknown-unknown") test_target_arch(wasm64 "" "--target=wasm64-unknown-unknown")
endif() endif()
set(COMPILER_RT_OS_SUFFIX "") set(COMPILER_RT_OS_SUFFIX "")
endif() endif()
endmacro() endmacro()