add implementation and tests for virtual function renaming
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
haven't found anything else
clang-rename/USRFindingAction.cpp | ||
---|---|---|
62 ↗ | (On Diff #64133) | const auto &OverridenMethod |
clang-rename/USRFindingAction.cpp | ||
---|---|---|
62 ↗ | (On Diff #64133) | Fixed; thanks! |
clang-rename/USRFindingAction.cpp | ||
---|---|---|
12 ↗ | (On Diff #64228) | ... at <offset>, as well as all relevant USRs. |
60 ↗ | (On Diff #64228) | I'd use early exit here: |
62 ↗ | (On Diff #64228) | This is n^3, right? (for each virtual method we run over all overrides, searching through all USRs) |
144 ↗ | (On Diff #64228) | Having all side-effects in the constructor is really unexpected to me. I'd add a Find() method. |
clang-rename/USRFindingAction.cpp | ||
---|---|---|
48 ↗ | (On Diff #64285) | Thanks for the feedback! |
clang-rename/USRFindingAction.cpp | ||
---|---|---|
45 ↗ | (On Diff #64285) | Still pondering whether 'relevant' is a good name here... |
72 ↗ | (On Diff #64285) | That way, the matchers don't actually get us too much - I'd hoped we already had an hasOverriddenMethod matcher (apparently we don't). It might make sense to implement one. |
86 ↗ | (On Diff #64285) | Perhaps call this addUSRsFromOverrideSets or something? addRelevantUSRs doesn't really tell me anything about what it does, and it's currently pretty specific. |