This is an archive of the discontinued LLVM Phabricator instance.

[MC] Add command-line option to choose the max nest level in asm macros
ClosedPublic

Authored by t83wCSLq on Jul 13 2016, 12:39 PM.

Details

Summary

This patch adds a command-line option (-asm-macro-max-nesting-depth <n>) to choose the maximum nesting level in assembly macros.

Diff Detail

Event Timeline

t83wCSLq retitled this revision from to [MC] Add command-line option to choose the max nest level in asm macros.
t83wCSLq updated this object.
t83wCSLq added a subscriber: llvm-commits.

Who should I add as reviewers?

davide added a subscriber: davide.

I think Rafael is in a good position to review this

rafael edited reviewers, added: grosbach; removed: rafael.Jul 15 2016, 5:03 AM
rafael added a subscriber: rafael.

I think Rafael is in a good position to review this

Unfortunately no. I am cutting down my involvement with LLVM.
Adding the code owner instead.

Pinging this hoping someone can review the patch.
(code owner does not seem active)

davide edited edge metadata.

Sorry for the delay, this shouldn't happen. I think the code is correct, but you should come up with a testcase.
Eric, any thoughts on the limit?

t83wCSLq edited edge metadata.

Added a testcase.

Fixing space typo.

This revision was automatically updated to reflect the committed changes.

Committed (r276842). Sorry if this took an unreasonable amount of time.

echristo edited edge metadata.Sep 22 2016, 3:36 PM

Out of curiosity, why? :)

-eric