Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[CodeGen] Take a MachineMemOperand::Flags in MachineFunction::getMachineMemOperand.
ClosedPublic
Actions

Authored by jlebar on Jul 12 2016, 3:04 PM.

Details

Reviewers

Commits

rG0af80cd6f0b0: [CodeGen] Take a MachineMemOperand::Flags in MachineFunction…
rL275591: [CodeGen] Take a MachineMemOperand::Flags in MachineFunction…

Summary

Previously we took an unsigned.

Hooray for type-safety.

Diff Detail

Repository: rL LLVM

Event Timeline

jlebar updated this revision to Diff 63734.Jul 12 2016, 3:04 PM

jlebar retitled this revision from to [CodeGen] Take a MachineMemOperand::Flags in MachineFunction::getMachineMemOperand..

jlebar updated this object.

jlebar added a reviewer: chandlerc.

jlebar added a subscriber: llvm-commits.

Herald added a subscriber: dsanders. · View Herald TranscriptJul 12 2016, 3:04 PM

jlebar added a child revision: D22249: Get rid of bool parameters in SelectionDAG::getLoad, getStore, and friends..Jul 12 2016, 3:05 PM

jlebar added a parent revision: D22281: [CodeGen] Refactor MachineMemOperand's Flags enum..

LGTM, thanks again for all the cleanup!

This revision is now accepted and ready to land.Jul 14 2016, 5:46 PM

Closed by commit rL275591: [CodeGen] Take a MachineMemOperand::Flags in MachineFunction… (authored by jlebar). · Explain WhyJul 15 2016, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

include/

llvm/

CodeGen/

MachineFunction.h

5 lines

lib/

CodeGen/

MIRParser/

MIParser.cpp

8 lines

MachineFunction.cpp

13 lines

SelectionDAG/

FastISel.cpp

2 lines

SelectionDAG.cpp

16 lines

SelectionDAGBuilder.cpp

2 lines

TargetInstrInfo.cpp

2 lines

TargetLoweringBase.cpp

2 lines

Target/

AArch64/

AArch64FastISel.cpp

6 lines

ARM/

ARMBaseInstrInfo.cpp

4 lines

ARMFastISel.cpp

5 lines

ARMInstrInfo.cpp

4 lines

Hexagon/

HexagonSplitDouble.cpp

2 lines

Mips/

MipsInstrInfo.h

2 lines

MipsInstrInfo.cpp

7 lines

SystemZ/

SystemZInstrBuilder.h

2 lines

X86/

X86InstrBuilder.h

2 lines

X86InstrInfo.cpp

4 lines

XCore/

XCoreFrameLowering.cpp

5 lines

Diff 64173

View Options

llvm/trunk/include/llvm/CodeGen/MachineFunction.h

View Options

llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp

View Options

llvm/trunk/lib/CodeGen/MachineFunction.cpp

View Options

llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp

View Options

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

View Options

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

View Options

llvm/trunk/lib/CodeGen/TargetInstrInfo.cpp

View Options

llvm/trunk/lib/CodeGen/TargetLoweringBase.cpp

View Options

llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp

View Options

llvm/trunk/lib/Target/ARM/ARMBaseInstrInfo.cpp

View Options

llvm/trunk/lib/Target/ARM/ARMFastISel.cpp

View Options

llvm/trunk/lib/Target/ARM/ARMInstrInfo.cpp

View Options

llvm/trunk/lib/Target/Hexagon/HexagonSplitDouble.cpp

View Options

llvm/trunk/lib/Target/Mips/MipsInstrInfo.h

View Options

llvm/trunk/lib/Target/Mips/MipsInstrInfo.cpp

View Options

llvm/trunk/lib/Target/SystemZ/SystemZInstrBuilder.h

View Options

llvm/trunk/lib/Target/X86/X86InstrBuilder.h

View Options

llvm/trunk/lib/Target/X86/X86InstrInfo.cpp

View Options

llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[CodeGen] Take a MachineMemOperand::Flags in MachineFunction::getMachineMemOperand.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 64173

llvm/trunk/include/llvm/CodeGen/MachineFunction.h

llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp

llvm/trunk/lib/CodeGen/MachineFunction.cpp

llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

llvm/trunk/lib/CodeGen/TargetInstrInfo.cpp

llvm/trunk/lib/CodeGen/TargetLoweringBase.cpp

llvm/trunk/lib/Target/AArch64/AArch64FastISel.cpp

llvm/trunk/lib/Target/ARM/ARMBaseInstrInfo.cpp

llvm/trunk/lib/Target/ARM/ARMFastISel.cpp

llvm/trunk/lib/Target/ARM/ARMInstrInfo.cpp

llvm/trunk/lib/Target/Hexagon/HexagonSplitDouble.cpp

llvm/trunk/lib/Target/Mips/MipsInstrInfo.h

llvm/trunk/lib/Target/Mips/MipsInstrInfo.cpp

llvm/trunk/lib/Target/SystemZ/SystemZInstrBuilder.h

llvm/trunk/lib/Target/X86/X86InstrBuilder.h

llvm/trunk/lib/Target/X86/X86InstrInfo.cpp

llvm/trunk/lib/Target/XCore/XCoreFrameLowering.cpp

[CodeGen] Take a MachineMemOperand::Flags in MachineFunction::getMachineMemOperand.
ClosedPublic
Actions

Revision Contents
Changeset List