Page MenuHomePhabricator

[asan] Fix interception unittest on Windows64.
ClosedPublic

Authored by wang0109 on Jul 12 2016, 12:18 PM.

Details

Summary

mov edi,edi is _not_ NOP in 64-bit, use 66,90h instead.
This bug was causing interception unittest to crash on Windows64.

Credits to etienneb for finding the root cause.

Diff Detail

Repository
rL LLVM

Event Timeline

wang0109 updated this revision to Diff 63710.Jul 12 2016, 12:18 PM
wang0109 retitled this revision from to [asan] Fix interception unittest on Windows64..
wang0109 updated this object.
wang0109 added subscribers: etienneb, chrisha.
rnk accepted this revision.Jul 12 2016, 12:43 PM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 12 2016, 12:43 PM
This revision was automatically updated to reflect the committed changes.